Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provider: Converts conns.AWSClient IgnoreTagsConfig to function and adds transparent tagging to several data sources #39761

Merged
merged 20 commits into from
Oct 18, 2024
Merged

provider: Converts conns.AWSClient IgnoreTagsConfig to function and adds transparent tagging to several data sources #39761

merged 20 commits into from
Oct 18, 2024

Conversation

gdavison
Copy link
Contributor

Description

Converts conns.AWSClient IgnoreTagsConfig to function and adds transparent tagging to several data sources. Adds tagging tests as needed

@gdavison gdavison requested a review from a team as a code owner October 17, 2024 00:12
@github-actions GitHub Actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/iam Issues and PRs that pertain to the iam service. service/ec2 Issues and PRs that pertain to the ec2 service. service/route53 Issues and PRs that pertain to the route53 service. service/elbv2 Issues and PRs that pertain to the elbv2 service. service/sns Issues and PRs that pertain to the sns service. service/directconnect Issues and PRs that pertain to the directconnect service. service/codebuild Issues and PRs that pertain to the codebuild service. service/acm Issues and PRs that pertain to the acm service. service/elb Issues and PRs that pertain to the elb service. service/inspector Issues and PRs that pertain to the inspector service. service/medialive Issues and PRs that pertain to the medialive service. service/autoscaling Issues and PRs that pertain to the autoscaling service. service/mq Issues and PRs that pertain to the mq service. service/dynamodb Issues and PRs that pertain to the dynamodb service. service/efs Issues and PRs that pertain to the efs service. service/servicediscovery Issues and PRs that pertain to the servicediscovery service. service/servicecatalog Issues and PRs that pertain to the servicecatalog service. service/budgets Issues and PRs that pertain to the budgets service. service/elasticache Issues and PRs that pertain to the elasticache service. service/glue Issues and PRs that pertain to the glue service. service/kinesis Issues and PRs that pertain to the kinesis service. service/elasticsearch Issues and PRs that pertain to the elasticsearch service. service/batch Issues and PRs that pertain to the batch service. provider Pertains to the provider itself, rather than any interaction with AWS. service/route53domains Issues and PRs that pertain to the route53domains service. service/eks Issues and PRs that pertain to the eks service. labels Oct 17, 2024
@github-actions github-actions bot added service/oam Issues and PRs that pertain to the oam service. service/vpclattice Issues and PRs that pertain to the vpclattice service. service/meta Issues and PRs that pertain to the meta service. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Oct 17, 2024
@gdavison
Makes conns.AWSClient IgnoreTagsConfig a function
c7ed5dd
@gdavison
Removes unneeded //lintignore:AWSR002
3eebf33
@gdavison
Adds tag testing generator to backup
0f6f981
@gdavison
Adds tagging tests for aws_backup_framework
c93ff38
@gdavison
Uses transparent tagging for data.aws_backup_framework
b5e05e1
@gdavison
Adds tagging tests for aws_backup_plan
c5e2c9b
@gdavison
Uses transparent tagging for data.aws_backup_plan
9519b67
@gdavison
Adds tagging tests for aws_backup_report_plan
4de77f5
@gdavison
Uses transparent tagging for data.aws_backup_report_plan
56117ed
@gdavison
Adds tagging tests for aws_backup_vault
3053a02
@gdavison
Uses transparent tagging for data.aws_backup_vault
ad16421
@gdavison
Adds tag testing generator to budgets
56de53f
@gdavison
Returns error if name not set
af7c02b
@gdavison
Adds tagging tests for aws_budgets_budget
b624da4
@gdavison
Uses transparent tagging for data.aws_budgets_budget
b063133
@gdavison
Uses transparent tagging for data.aws_dynamodb_table
866738e
@gdavison
Uses transparent tagging for data.aws_subnet
f0f3d75
@gdavison
Uses transparent tagging for data.aws_sns_topic
3d507ff
@gdavison gdavison force-pushed the td-ignore-tags-config-function branch from bed2f40 to 3d507ff Compare October 17, 2024 00:18
ewbankkit
ewbankkit approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccBudgetsBudgetDataSource_' PKG=budgets
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.2 test ./internal/service/budgets/... -v -count 1 -parallel 20  -run=TestAccBudgetsBudgetDataSource_ -timeout 360m
2024/10/17 08:16:01 Initializing Terraform AWS Provider...
=== RUN   TestAccBudgetsBudgetDataSource_tags
=== PAUSE TestAccBudgetsBudgetDataSource_tags
=== RUN   TestAccBudgetsBudgetDataSource_tags_NullMap
=== PAUSE TestAccBudgetsBudgetDataSource_tags_NullMap
=== RUN   TestAccBudgetsBudgetDataSource_tags_EmptyMap
=== PAUSE TestAccBudgetsBudgetDataSource_tags_EmptyMap
=== RUN   TestAccBudgetsBudgetDataSource_tags_DefaultTags_nonOverlapping
=== PAUSE TestAccBudgetsBudgetDataSource_tags_DefaultTags_nonOverlapping
=== RUN   TestAccBudgetsBudgetDataSource_tags_IgnoreTags_Overlap_DefaultTag
=== PAUSE TestAccBudgetsBudgetDataSource_tags_IgnoreTags_Overlap_DefaultTag
=== RUN   TestAccBudgetsBudgetDataSource_tags_IgnoreTags_Overlap_ResourceTag
=== PAUSE TestAccBudgetsBudgetDataSource_tags_IgnoreTags_Overlap_ResourceTag
=== RUN   TestAccBudgetsBudgetDataSource_basic
=== PAUSE TestAccBudgetsBudgetDataSource_basic
=== CONT  TestAccBudgetsBudgetDataSource_tags
=== CONT  TestAccBudgetsBudgetDataSource_tags_EmptyMap
=== CONT  TestAccBudgetsBudgetDataSource_tags_IgnoreTags_Overlap_DefaultTag
=== CONT  TestAccBudgetsBudgetDataSource_tags_DefaultTags_nonOverlapping
=== CONT  TestAccBudgetsBudgetDataSource_basic
=== CONT  TestAccBudgetsBudgetDataSource_tags_NullMap
=== CONT  TestAccBudgetsBudgetDataSource_tags_IgnoreTags_Overlap_ResourceTag
--- PASS: TestAccBudgetsBudgetDataSource_tags_NullMap (22.06s)
--- PASS: TestAccBudgetsBudgetDataSource_tags_EmptyMap (22.21s)
--- PASS: TestAccBudgetsBudgetDataSource_tags_DefaultTags_nonOverlapping (22.22s)
--- PASS: TestAccBudgetsBudgetDataSource_tags (22.25s)
--- PASS: TestAccBudgetsBudgetDataSource_tags_IgnoreTags_Overlap_DefaultTag (22.34s)
--- PASS: TestAccBudgetsBudgetDataSource_tags_IgnoreTags_Overlap_ResourceTag (22.98s)
--- PASS: TestAccBudgetsBudgetDataSource_basic (37.36s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/budgets	42.691s

@gdavison gdavison merged commit 86856ac into main Oct 18, 2024
39 checks passed
@gdavison gdavison deleted the td-ignore-tags-config-function branch October 18, 2024 19:45
@github-actions github-actions bot added this to the v5.73.0 milestone Oct 18, 2024
terraform-aws-provider bot pushed a commit that referenced this pull request Oct 18, 2024
Update CHANGELOG.md for #39761
9dfc700
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
client-connections Pertains to the AWS Client and service connections. documentation Introduces or discusses updates to documentation. generators Relates to code generators. linter Pertains to changes to or issues with the various linters. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. provider Pertains to the provider itself, rather than any interaction with AWS. service/acm Issues and PRs that pertain to the acm service. service/apigatewayv2 Issues and PRs that pertain to the apigatewayv2 service. service/auditmanager Issues and PRs that pertain to the auditmanager service. service/autoscaling Issues and PRs that pertain to the autoscaling service. service/backup Issues and PRs that pertain to the backup service. service/batch Issues and PRs that pertain to the batch service. service/budgets Issues and PRs that pertain to the budgets service. service/ce Issues and PRs that pertain to the ce service. service/codebuild Issues and PRs that pertain to the codebuild service. service/codestarconnections Issues and PRs that pertain to the codestarconnections service. service/cognitoidp Issues and PRs that pertain to the cognitoidp service. service/directconnect Issues and PRs that pertain to the directconnect service. service/ds Issues and PRs that pertain to the ds service. service/dynamodb Issues and PRs that pertain to the dynamodb service. service/ec2 Issues and PRs that pertain to the ec2 service. service/efs Issues and PRs that pertain to the efs service. service/eks Issues and PRs that pertain to the eks service. service/elasticache Issues and PRs that pertain to the elasticache service. service/elasticsearch Issues and PRs that pertain to the elasticsearch service. service/elb Issues and PRs that pertain to the elb service. service/elbv2 Issues and PRs that pertain to the elbv2 service. service/fsx Issues and PRs that pertain to the fsx service. service/globalaccelerator Issues and PRs that pertain to the globalaccelerator service. service/glue Issues and PRs that pertain to the glue service. service/iam Issues and PRs that pertain to the iam service. service/imagebuilder Issues and PRs that pertain to the imagebuilder service. service/inspector Issues and PRs that pertain to the inspector service. service/ipam Issues and PRs that pertain to the ipam service. service/ivs Issues and PRs that pertain to the ivs service. service/kafka Issues and PRs that pertain to the kafka service. service/kendra Issues and PRs that pertain to the kendra service. service/kinesis Issues and PRs that pertain to the kinesis service. service/location Issues and PRs that pertain to the location service. service/medialive Issues and PRs that pertain to the medialive service. service/memorydb Issues and PRs that pertain to the memorydb service. service/meta Issues and PRs that pertain to the meta service. service/mq Issues and PRs that pertain to the mq service. service/networkmanager Issues and PRs that pertain to the networkmanager service. service/oam Issues and PRs that pertain to the oam service. service/opensearch Issues and PRs that pertain to the opensearch service. service/opensearchserverless Issues and PRs that pertain to the opensearchserverless service. service/outposts Issues and PRs that pertain to the outposts service. service/qldb Issues and PRs that pertain to the qldb service. service/quicksight Issues and PRs that pertain to the quicksight service. service/route53domains Issues and PRs that pertain to the route53domains service. service/route53resolver Issues and PRs that pertain to the route53resolver service. service/route53 Issues and PRs that pertain to the route53 service. service/servicecatalog Issues and PRs that pertain to the servicecatalog service. service/servicediscovery Issues and PRs that pertain to the servicediscovery service. service/signer Issues and PRs that pertain to the signer service. service/sns Issues and PRs that pertain to the sns service. service/ssmcontacts Issues and PRs that pertain to the ssmcontacts service. service/ssmincidents Issues and PRs that pertain to the ssmincidents service. service/ssoadmin Issues and PRs that pertain to the ssoadmin service. service/transfer Issues and PRs that pertain to the transfer service. service/vpc Issues and PRs that pertain to the vpc service. service/vpclattice Issues and PRs that pertain to the vpclattice service. skaff Issues and pull requested related to the skaff tool tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. verify Pertains to the verify package (i.e., provider-level validating, diff suppression, etc.)
Projects
None yet
Milestone
v5.73.0
Development

Successfully merging this pull request may close these issues.
2 participants
@gdavison @ewbankkit