Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/sagemaker_feature_group - add support for feature_definition.collection_config, feature_definition.collection_type, and throughput_config #39805

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Oct 19, 2024

Description

Relations

Closes #0000

References

Output from Acceptance Testing

% make testacc TESTS=TestAccSageMakerFeatureGroup_  PKG=sagemaker 

--- PASS: TestAccSageMakerFeatureGroup_serial/featureDefinition_collectionType (1080.56s)
--- PASS: TestAccSageMakerFeatureGroup_serial/offlineConfig_basic (65.26s)
--- PASS: TestAccSageMakerFeatureGroup_serial/throughputConfig (90.76s)
--- PASS: TestAccSageMakerFeatureGroup_serial/featureDefinition_collectionConfig (987.91s)

Signed-off-by: drfaust92 <[email protected]>
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/sagemaker Issues and PRs that pertain to the sagemaker service. needs-triage Waiting for first response or review from a maintainer. external-maintainer Contribution from a trusted external contributor. labels Oct 19, 2024
Signed-off-by: drfaust92 <[email protected]>
@DrFaust92 DrFaust92 added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 19, 2024
Signed-off-by: drfaust92 <[email protected]>
Signed-off-by: drfaust92 <[email protected]>
@DrFaust92 DrFaust92 marked this pull request as ready for review October 19, 2024 02:05
@DrFaust92 DrFaust92 requested a review from a team as a code owner October 19, 2024 02:05
Signed-off-by: drfaust92 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. external-maintainer Contribution from a trusted external contributor. service/sagemaker Issues and PRs that pertain to the sagemaker service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant