Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_sns_topic_subscription: Always set Terraform state on reads, fix filter_policy removal #6023

Merged
merged 1 commit into from
Oct 3, 2018

Commits on Sep 28, 2018

  1. resource/aws_sns_topic_subscription: Always set Terraform state on re…

    …ads, fix filter_policy removal
    
    Previously (before code updates):
    
    ```
    --- FAIL: TestAccAWSSNSTopicSubscription_basic (10.89s)
        testing.go:527: Step 0 error: Check failed: Check 3/8 error: aws_sns_topic_subscription.test_subscription: Attribute 'delivery_policy' not found
    --- FAIL: TestAccAWSSNSTopicSubscription_filterPolicy (28.36s)
        testing.go:527: Step 3 error: Error applying: 1 error occurred:
            	* aws_sns_topic_subscription.test_subscription: 1 error occurred:
            	* aws_sns_topic_subscription.test_subscription: error setting subscription (arn:aws:sns:us-west-2:187416307283:terraform-test-topic-7447862065639079919:d0385467-b42a-4018-a22f-cdd19066fe18) attribute (FilterPolicy): InvalidParameter: Invalid parameter: FilterPolicy: Filter is not an object
    ```
    
    Output from acceptance testing:
    
    ```
    --- PASS: TestAccAWSSNSTopicSubscription_basic (15.92s)
    --- PASS: TestAccAWSSNSTopicSubscription_filterPolicy (34.20s)
    --- PASS: TestAccAWSSNSTopicSubscription_deliveryPolicy (33.09s)
    --- PASS: TestAccAWSSNSTopicSubscription_rawMessageDelivery (31.41s)
    --- PASS: TestAccAWSSNSTopicSubscription_autoConfirmingEndpoint (44.73s)
    --- PASS: TestAccAWSSNSTopicSubscription_autoConfirmingSecuredEndpoint (75.19s)
    ```
    bflad committed Sep 28, 2018
    Configuration menu
    Copy the full SHA
    1e72c19 View commit details
    Browse the repository at this point in the history