Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide aws_kms_ciphertext plaintext attribute #6100

Merged
merged 2 commits into from
Mar 26, 2019

Conversation

julienduchesne
Copy link
Contributor

Changes proposed in this pull request:
We wish to hide these logs:

<= read (data resources)

Terraform will perform the following actions:

 <= data.aws_kms_ciphertext.something
      id:                                  <computed>
      ciphertext_blob:                     <computed>
      key_id:                              "something"
      plaintext:                           "my password"

@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/kms Issues and PRs that pertain to the kms service. labels Oct 9, 2018
@bflad bflad added the enhancement Requests to existing resources that expand the functionality or scope. label Mar 26, 2019
@bflad bflad added this to the v2.4.0 milestone Mar 26, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much @julienduchesne 🚀 Sorry for the delay here.

--- PASS: TestAccDataSourceAwsKmsCiphertext_basic (41.18s)
--- PASS: TestAccDataSourceAwsKmsCiphertext_validate_withContext (41.31s)
--- PASS: TestAccDataSourceAwsKmsCiphertext_validate (41.47s)

@bflad bflad merged commit e8aa6af into hashicorp:master Mar 26, 2019
bflad added a commit that referenced this pull request Mar 26, 2019
@bflad
Copy link
Contributor

bflad commented Mar 29, 2019

This has been released in version 2.4.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@julienduchesne julienduchesne deleted the hide-plaintext-ciphertext branch April 25, 2019 16:44
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/kms Issues and PRs that pertain to the kms service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants