Cloudfront Distribution: Origin Groups support

[barrytam20]

Fixes #6547

Changes proposed in this pull request:

• Added origin groups resource in resource_aws_cloudfront_distribution
• added expanding, flattening, and hashing for origin groups in cloudfront_distribution_configuration_structure
• website documentation update

Output from added unit testing:

make test TEST=./aws TESTARGS='-run=Test.*OriginGroups'
==> Checking that code complies with gofmt requirements...
go test ./aws -timeout=30s -parallel=4
ok  	github.com/terraform-providers/terraform-provider-aws/aws	2.839s

acceptance tests were taken from PR #7145, however, my corporate account is not letting me create buckets and preventing me from running them

[barrytam20]

@bflad going by the amount of contributor pull requests out there, looks like you guys are busy prepping for the terraform 0.12 release. Any chance you guys can give this a review? We would really like to have this feature

[barrytam20]

fixed hash values in test, ran on my personal aws account

make testacc TEST=./aws TESTARGS='-run=TestAccAWSCloudFrontDistribution_OriginGroups'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSCloudFrontDistribution_OriginGroups -timeout 120m
=== RUN   TestAccAWSCloudFrontDistribution_OriginGroups
=== PAUSE TestAccAWSCloudFrontDistribution_OriginGroups
=== CONT  TestAccAWSCloudFrontDistribution_OriginGroups
--- PASS: TestAccAWSCloudFrontDistribution_OriginGroups (37.06s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       37.098s

[barrytam20]

@bflad small bump to get this PR noticed :)

[queeno]

Hey there, could you please rebase and resolve the conflicts?
Thanks :-)

[bflad]

Sorry for rebase mess, we have been doing a bunch of bug fixes and cleanup with this resource. 😅

Once that is sorted, we would like to take a look at this but it appears there are two conflicting pull requests for this functionality (this and #7145). Since we cannot merge both as one is not a superset of the other, we ask that the authors work out an arrangement for which pull request to move forward. Thanks so much for your work here so far.

[barrytam20]

@queeno @bflad i merged in upstream changes and resolved the conflicts

@cl3086 would you mind if we move forward with this PR as opposed to yours (#7145)? i think this one is a bit further along

[queeno]

Thanks @barrytam20
Let's try to get this merged and released asap. I have the feeling that many many people around the world will be grateful 👍

[cl3086]

The other PR has been closed @barrytam20 !

[bflad]

Thanks so much @barrytam20 and @cl3086 -- for full transparency I know at least personally I won't be able to look at this for a week or two due to my focus being elsewhere, but at quick glance this looks like its off to a good start and maybe other maintainers or community members can chime in. 👍

[bflad]

Hi @barrytam20 👋 Thanks so much for this contribution. I left some initial feedback below which will potentially influence further feedback so stopping here. Please reach out if you have any questions or do not have time to implement these items. 👍

[barrytam20]

hey @bflad, thanks for the advice!

i've made some changes as per your recommendations. Output from testing is

Barrys-MBP:terraform-provider-aws barrytam$ make test TEST=./aws TESTARGS='-run=Test.*OriginGroups'
==> Checking that code complies with gofmt requirements...
go test ./aws -timeout=30s -parallel=4
ok  	github.com/barrytam20/terraform-provider-aws/aws	0.271s
Barrys-MBP:terraform-provider-aws barrytam$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSCloudFrontDistribution_OriginGroups'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSCloudFrontDistribution_OriginGroups -timeout 120m
=== RUN   TestAccAWSCloudFrontDistribution_OriginGroups
=== PAUSE TestAccAWSCloudFrontDistribution_OriginGroups
=== CONT  TestAccAWSCloudFrontDistribution_OriginGroups
--- PASS: TestAccAWSCloudFrontDistribution_OriginGroups (1172.75s)
PASS
ok  	github.com/barrytam20/terraform-provider-aws/aws	1172.793s

[bflad]

Looks great, @barrytam20, thanks so much for the updates 🚀

--- PASS: TestAccAWSCloudFrontDistribution_customOrigin (1987.24s)
--- PASS: TestAccAWSCloudFrontDistribution_disappears (517.03s)
--- PASS: TestAccAWSCloudFrontDistribution_Enabled (2576.87s)
--- PASS: TestAccAWSCloudFrontDistribution_HTTP11Config (1100.14s)
--- PASS: TestAccAWSCloudFrontDistribution_IsIPV6EnabledConfig (1106.13s)
--- PASS: TestAccAWSCloudFrontDistribution_multiOrigin (1175.69s)
--- PASS: TestAccAWSCloudFrontDistribution_noCustomErrorResponseConfig (1101.07s)
--- PASS: TestAccAWSCloudFrontDistribution_noOptionalItemsConfig (1987.73s)
--- PASS: TestAccAWSCloudFrontDistribution_orderedCacheBehavior (1991.00s)
--- PASS: TestAccAWSCloudFrontDistribution_Origin_EmptyDomainName (1.87s)
--- PASS: TestAccAWSCloudFrontDistribution_Origin_EmptyOriginID (1.82s)
--- PASS: TestAccAWSCloudFrontDistribution_OriginGroups (1986.48s)
--- PASS: TestAccAWSCloudFrontDistribution_RetainOnDelete (1103.66s)
--- PASS: TestAccAWSCloudFrontDistribution_S3Origin (1175.76s)
--- PASS: TestAccAWSCloudFrontDistribution_S3OriginWithTags (1769.72s)
--- PASS: TestAccAWSCloudFrontDistribution_ViewerCertificate_AcmCertificateArn (1993.18s)
--- PASS: TestAccAWSCloudFrontDistribution_ViewerCertificate_AcmCertificateArn_ConflictsWithCloudFrontDefaultCertificate (1993.35s)

[bflad]

One last documentation update required since the schema was updated, but since it is very minor and everything else looks great, will fix this on merge so we can get this out there and start fixing some other (unrelated) aws_cloudfront_distribution bugs. 😄

[bflad]

This has been released in version 2.3.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!