Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: support for opsworks for chef automate #7817

Closed
wants to merge 16 commits into from

Commits on Mar 5, 2019

  1. it compiles

    It's missing a bunch of stuff, for sure, like parameters, tests, docs,
    etc, and I haven't actually run it against aws, but I have what I think
    is all of the boilerplate required, so it's a start
    kitchen committed Mar 5, 2019
    Configuration menu
    Copy the full SHA
    05af368 View commit details
    Browse the repository at this point in the history
  2. add some parameters

    I grabbed all of these from the API docs:
    https://docs.aws.amazon.com/sdk-for-go/api/service/opsworkscm/#CreateServerInput
    
    It's still not entirely there, and I'll need to document the
    instance/service profile ARN stuff, and the security groups since
    I think the security groups need to be made outside and not automanaged
    by the server resource on AWS's side
    kitchen committed Mar 5, 2019
    Configuration menu
    Copy the full SHA
    d64c822 View commit details
    Browse the repository at this point in the history
  3. send the parameters to the api

    everything is there but the EngineAttributes bit and validation.
    
    also debating still on whether some of those required params should be
    optional. I'd like them to be required, but I'll have to ask upstream
    their thoughts
    kitchen committed Mar 5, 2019
    Configuration menu
    Copy the full SHA
    a4b72ae View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3cc6329 View commit details
    Browse the repository at this point in the history
  5. make these required

    They already are required because of the way I made the Create function,
    so while it's still an open question whether or not they should actually
    be required required, I at least want to make it consistent at the
    moment
    kitchen committed Mar 5, 2019
    Configuration menu
    Copy the full SHA
    cac53cb View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    cdf44d2 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2019

  1. starting to work on tests

    I think this is the baseline requirements for setting up the
    opsworks_chef instance. It's ... verbose. But this is also a fairly
    complex thing to be creating, so that's kinda to be expected, methinks.
    kitchen committed Mar 6, 2019
    Configuration menu
    Copy the full SHA
    2641e0d View commit details
    Browse the repository at this point in the history
  2. ForceNew on these

    per discussion in the PR, I think ForceNew here is probably a bad idea
    because it will almost certainly destroy any node associations, but at
    least it won't silently do nothing :)
    kitchen committed Mar 6, 2019
    Configuration menu
    Copy the full SHA
    0cad028 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    94b271c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6603197 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    ec3a977 View commit details
    Browse the repository at this point in the history
  6. register the resource

    kitchen committed Mar 6, 2019
    Configuration menu
    Copy the full SHA
    a0cce4d View commit details
    Browse the repository at this point in the history
  7. validation stuff

    kitchen committed Mar 6, 2019
    Configuration menu
    Copy the full SHA
    61fb889 View commit details
    Browse the repository at this point in the history
  8. need to Elem for TypeList

    kitchen committed Mar 6, 2019
    Configuration menu
    Copy the full SHA
    206e2f9 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2019

  1. some fixes for the actual test code

    since this doesn't seem to be running yet (I think this only runs in
    acceptance tests?) it doesn't explode, but I'm testing something like it
    elsewhere
    kitchen committed Mar 7, 2019
    Configuration menu
    Copy the full SHA
    71fa201 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2019

  1. Configuration menu
    Copy the full SHA
    96f3661 View commit details
    Browse the repository at this point in the history