Support ALB Advanced Routing rules #8268

dpiddockcmp · 2019-04-10T10:45:15Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Changes proposed in this pull request:

Support the new ALB Advanced Routing Rules https://docs.aws.amazon.com/elasticloadbalancing/latest/APIReference/API_RuleCondition.html
Provide migration path from the old condition.field and condition.values keys and deprecate them

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSLBListenerRule'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 4 -run=TestAccAWSLBListenerRule -timeout 120m
=== RUN   TestAccAWSLBListenerRule_basic
=== PAUSE TestAccAWSLBListenerRule_basic
=== RUN   TestAccAWSLBListenerRuleBackwardsCompatibility
=== PAUSE TestAccAWSLBListenerRuleBackwardsCompatibility
=== RUN   TestAccAWSLBListenerRule_redirect
=== PAUSE TestAccAWSLBListenerRule_redirect
=== RUN   TestAccAWSLBListenerRule_fixedResponse
=== PAUSE TestAccAWSLBListenerRule_fixedResponse
=== RUN   TestAccAWSLBListenerRule_updateRulePriority
=== PAUSE TestAccAWSLBListenerRule_updateRulePriority
=== RUN   TestAccAWSLBListenerRule_changeListenerRuleArnForcesNew
=== PAUSE TestAccAWSLBListenerRule_changeListenerRuleArnForcesNew
=== RUN   TestAccAWSLBListenerRule_multipleConditionThrowsError
=== PAUSE TestAccAWSLBListenerRule_multipleConditionThrowsError
=== RUN   TestAccAWSLBListenerRule_priority
=== PAUSE TestAccAWSLBListenerRule_priority
=== RUN   TestAccAWSLBListenerRule_cognito
=== PAUSE TestAccAWSLBListenerRule_cognito
=== RUN   TestAccAWSLBListenerRule_oidc
=== PAUSE TestAccAWSLBListenerRule_oidc
=== RUN   TestAccAWSLBListenerRule_Action_Order
=== PAUSE TestAccAWSLBListenerRule_Action_Order
=== RUN   TestAccAWSLBListenerRule_Action_Order_Recreates
=== PAUSE TestAccAWSLBListenerRule_Action_Order_Recreates
=== RUN   TestAccAWSLBListenerRule_conditionAttributesCount
=== PAUSE TestAccAWSLBListenerRule_conditionAttributesCount
=== RUN   TestAccAWSLBListenerRule_conditionHostHeader
=== PAUSE TestAccAWSLBListenerRule_conditionHostHeader
=== RUN   TestAccAWSLBListenerRule_conditionHostHeader_deprecated
=== PAUSE TestAccAWSLBListenerRule_conditionHostHeader_deprecated
=== RUN   TestAccAWSLBListenerRule_conditionHttpHeader
=== PAUSE TestAccAWSLBListenerRule_conditionHttpHeader
=== RUN   TestAccAWSLBListenerRule_conditionHttpHeader_invalid
=== PAUSE TestAccAWSLBListenerRule_conditionHttpHeader_invalid
=== RUN   TestAccAWSLBListenerRule_conditionHttpRequestMethod
=== PAUSE TestAccAWSLBListenerRule_conditionHttpRequestMethod
=== RUN   TestAccAWSLBListenerRule_conditionPathPattern
=== PAUSE TestAccAWSLBListenerRule_conditionPathPattern
=== RUN   TestAccAWSLBListenerRule_conditionPathPattern_deprecated
=== PAUSE TestAccAWSLBListenerRule_conditionPathPattern_deprecated
=== RUN   TestAccAWSLBListenerRule_conditionQueryString
=== PAUSE TestAccAWSLBListenerRule_conditionQueryString
=== RUN   TestAccAWSLBListenerRule_conditionSourceIp
=== PAUSE TestAccAWSLBListenerRule_conditionSourceIp
=== RUN   TestAccAWSLBListenerRule_conditionMultiple
=== PAUSE TestAccAWSLBListenerRule_conditionMultiple
=== CONT  TestAccAWSLBListenerRule_basic
=== CONT  TestAccAWSLBListenerRule_conditionAttributesCount
=== CONT  TestAccAWSLBListenerRule_Action_Order_Recreates
=== CONT  TestAccAWSLBListenerRule_Action_Order
--- PASS: TestAccAWSLBListenerRule_basic (274.83s)
=== CONT  TestAccAWSLBListenerRule_oidc
--- PASS: TestAccAWSLBListenerRule_Action_Order_Recreates (294.26s)
=== CONT  TestAccAWSLBListenerRule_cognito
--- PASS: TestAccAWSLBListenerRule_Action_Order (296.43s)
=== CONT  TestAccAWSLBListenerRule_priority
--- PASS: TestAccAWSLBListenerRule_oidc (272.91s)
=== CONT  TestAccAWSLBListenerRule_multipleConditionThrowsError
--- PASS: TestAccAWSLBListenerRule_multipleConditionThrowsError (2.29s)
=== CONT  TestAccAWSLBListenerRule_changeListenerRuleArnForcesNew
--- PASS: TestAccAWSLBListenerRule_cognito (302.83s)
=== CONT  TestAccAWSLBListenerRule_updateRulePriority
--- PASS: TestAccAWSLBListenerRule_conditionAttributesCount (759.26s)
=== CONT  TestAccAWSLBListenerRule_fixedResponse
--- PASS: TestAccAWSLBListenerRule_updateRulePriority (315.04s)
=== CONT  TestAccAWSLBListenerRule_redirect
--- PASS: TestAccAWSLBListenerRule_priority (640.36s)
=== CONT  TestAccAWSLBListenerRuleBackwardsCompatibility
--- PASS: TestAccAWSLBListenerRule_changeListenerRuleArnForcesNew (460.25s)
=== CONT  TestAccAWSLBListenerRule_conditionPathPattern
--- PASS: TestAccAWSLBListenerRule_fixedResponse (271.90s)
=== CONT  TestAccAWSLBListenerRule_conditionMultiple
--- PASS: TestAccAWSLBListenerRule_redirect (249.99s)
=== CONT  TestAccAWSLBListenerRule_conditionSourceIp
--- PASS: TestAccAWSLBListenerRuleBackwardsCompatibility (267.98s)
=== CONT  TestAccAWSLBListenerRule_conditionQueryString
--- PASS: TestAccAWSLBListenerRule_conditionPathPattern (270.64s)
=== CONT  TestAccAWSLBListenerRule_conditionPathPattern_deprecated
--- PASS: TestAccAWSLBListenerRule_conditionMultiple (264.14s)
=== CONT  TestAccAWSLBListenerRule_conditionHttpHeader
--- PASS: TestAccAWSLBListenerRule_conditionSourceIp (284.98s)
=== CONT  TestAccAWSLBListenerRule_conditionHttpRequestMethod
--- PASS: TestAccAWSLBListenerRule_conditionQueryString (250.74s)
=== CONT  TestAccAWSLBListenerRule_conditionHttpHeader_invalid
--- PASS: TestAccAWSLBListenerRule_conditionHttpHeader_invalid (2.32s)
=== CONT  TestAccAWSLBListenerRule_conditionHostHeader_deprecated
--- PASS: TestAccAWSLBListenerRule_conditionHttpHeader (251.61s)
=== CONT  TestAccAWSLBListenerRule_conditionHostHeader
--- PASS: TestAccAWSLBListenerRule_conditionPathPattern_deprecated (283.15s)
--- PASS: TestAccAWSLBListenerRule_conditionHostHeader_deprecated (279.90s)
--- PASS: TestAccAWSLBListenerRule_conditionHttpRequestMethod (328.54s)
--- PASS: TestAccAWSLBListenerRule_conditionHostHeader (293.96s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	1840.930s

Notes

conditions custom hasher:

This is required due to the backwards compatible way that AWS implemented the advanced routing. condition.values and the applicable config block are set when condition.field is host-header or path-pattern.
Using a custom hasher means that we can migrate from condition.field and condition.values to config block. Users do not see a Diff on every plan.
Can probably be removed on next major version, if desired, after removing condition.field and condition.values attributes.

cmayne-r7 · 2019-04-24T14:07:03Z

Hey guys, is there anything I can do to help out here? Is there a target date for release for this?

facundovictor

The format is acceptable and it would help on future changes if more conditions are added, or more details are required to be included in the specific condition type blocks 👍

@bflad do we have an estimate on when this may be reviewed/included for a release?

spider-network · 2019-05-09T09:15:56Z

@allanhahn: Any idea when it will be released?

cjgratacos · 2019-05-09T15:30:19Z

@allanhahn any updates on when this feature is going to be release?

KellerII · 2019-05-10T15:37:01Z

Any updates on when this feature will be released? This would be really helpful.

CC: @allanhahn

bradpritchard · 2019-05-10T15:51:34Z

Great work - our organization would definitely use this. Can we please get it merged in?

mvn-bachhuynh-dn · 2019-05-13T15:59:06Z

Really want multi values in a condition:

    field  = "path-pattern"
    values = ["/404", "/assets/*"]
  }

Please add

subzero112233 · 2019-05-14T09:39:35Z

is this going to be merged soon?

cemo · 2019-05-21T18:41:49Z

@bflad is this somehow missed? This is really crucial for us.

bharat109puri · 2019-05-22T17:59:22Z

Merge it please.

tomaszdudek7 · 2019-05-23T07:27:45Z

The only "workaround" right now is creating null_resource with local-exec provider that calls aws-cli for us. That is horrendous.

Please, merge!

pasali · 2019-05-27T06:40:51Z

@bflad is there any estimate on when will this PR merged ? We are really waiting for this feature.

dud225 · 2019-05-28T14:21:35Z

Please @bflad @ewbankkit @nywilken could you take some time to review this PR and comment it if something needs to be changed ?

t0klian · 2019-06-05T09:36:58Z

Hi Everyone! Is there any ETA on review and merge of this PR?

c-yokoyama · 2019-06-17T07:15:36Z

Could you please merge this PR? This is an important future for us.

adityaathalye · 2019-06-18T05:31:39Z

@bflad would it be feasible to merge this PR anytime soon? Echoing the sentiment of many commentators in this thread, this addition would help me fully terraform my ALB requirements.

Thank you for your time and effort. Cheers!

aeschright

Thank you so much! 🚀 🎉

--- PASS: TestAccAWSLBListenerRule_conditionQueryString (190.50s)
--- PASS: TestAccAWSLBListenerRule_conditionMultiple (201.69s)
--- PASS: TestAccAWSLBListenerRule_conditionHostHeader_deprecated (202.03s)
--- PASS: TestAccAWSLBListenerRule_changeListenerRuleArnForcesNew (203.73s)
--- PASS: TestAccAWSLBListenerRule_Action_Order_Recreates (204.14s)
--- PASS: TestAccAWSLBListenerRule_fixedResponse (206.32s)
--- PASS: TestAccAWSLBListenerRule_conditionHostHeader (208.64s)
--- PASS: TestAccAWSLBListenerRule_conditionPathPattern (210.67s)
--- PASS: TestAccAWSLBListenerRule_oidc (220.87s)
--- PASS: TestAccAWSLBListenerRule_conditionHttpHeader (226.07s)
--- PASS: TestAccAWSLBListenerRule_conditionPathPattern_deprecated (227.85s)
--- PASS: TestAccAWSLBListenerRule_conditionHttpRequestMethod (238.79s)
--- PASS: TestAccAWSLBListenerRuleBackwardsCompatibility (237.24s)
--- PASS: TestAccAWSLBListenerRule_Action_Order (251.73s)
--- PASS: TestAccAWSLBListenerRule_basic (268.04s)
--- PASS: TestAccAWSLBListenerRule_cognito (299.88s)
--- PASS: TestAccAWSLBListenerRule_redirect (299.05s)
--- PASS: TestAccAWSLBListenerRule_conditionSourceIp (309.71s)
--- PASS: TestAccAWSLBListenerRule_updateRulePriority (273.67s)
--- PASS: TestAccAWSLBListenerRule_priority (389.79s)

aeschright · 2019-12-06T20:53:27Z

This will be included in next week's release, v2.42.0.

dpiddockcmp · 2019-12-07T14:14:55Z

Wonderful! Thank you @aeschright .

barneyparker · 2019-12-07T20:45:45Z

@dpiddockcmp @aeschright Thank You for all your work on this! ❤️

dfens1 · 2019-12-07T23:08:58Z

Awesome! Thank you all!!

ArseniiPetrovich · 2019-12-09T11:22:33Z

Wow. Don't believe in it. Finally!

bharat109puri · 2019-12-09T11:47:28Z

Thanks, finally its merged. Was waiting for this from long time.

sandangel · 2019-12-11T02:35:31Z

will this have the new weighted target group feature?

dpiddockcmp · 2019-12-11T10:40:07Z

Hi @sandangel,

This PR has been merged and no further changes will be made to it.

Target group weighting is a feature of the forward Action. This PR was only adding the advanced routing rules which are part of the Conditions. Weighting would never have been added to this PR even if the feature had been released when this PR was being written.

Issue #10942 has been raised for weighted target groups but no PR so far.

ghost · 2019-12-13T19:55:34Z

This has been released in version 2.42.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

Fixes hashicorp#8126

Upstream change: hashicorp/terraform-provider-aws#8268 Should fix this warning: ``` Warning: "condition.0.values": [DEPRECATED] use 'host_header' or 'path_pattern' attribute instead on .terraform/modules/atlantis/terraform-aws-modules-terraform-aws-atlantis-e1242e3/main.tf line 213, in resource "aws_lb_listener_rule" "redirect_http_to_https": 213: resource "aws_lb_listener_rule" "redirect_http_to_https" { ```

This reverts commit ed2b1b2.

ghost · 2020-03-28T17:13:16Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

dpiddockcmp changed the title ~~[WIP] Support ALB Advanced Routing rules~~ Support ALB Advanced Routing rules Apr 12, 2019

sunilkumarmohanty mentioned this pull request Apr 15, 2019

aws_listener_rule forwarding using http request methods #8315

Closed

facundovictor reviewed Apr 25, 2019

View reviewed changes

ewbankkit mentioned this pull request May 3, 2019

Support ALB advanced request routing #8126

Closed

allanhahn approved these changes May 8, 2019

View reviewed changes

allanhahn approved these changes May 15, 2019

View reviewed changes

dhoeric mentioned this pull request Jun 7, 2019

Aggregate 5 paths condition into 1 rule moneysmartco/tf-aws-alb-app#10

Closed

bflad added this to the v2.18.0 milestone Jun 18, 2019

Remove redundant append()

5e0821f

aeschright added this to the v2.42.0 milestone Dec 6, 2019

aeschright approved these changes Dec 6, 2019

View reviewed changes

aeschright merged commit 923cc6e into hashicorp:master Dec 6, 2019

aeschright added a commit that referenced this pull request Dec 6, 2019

Update CHANGELOG for #8268

1d89e6d

dpiddockcmp deleted the 8126-alb-adv branch December 7, 2019 14:14

dhoeric mentioned this pull request Dec 16, 2019

Use ALB Advanced Routing rules moneysmartco/tf-aws-alb-app#11

Merged

gil-fugue pushed a commit to LuminalHQ/terraform-provider-aws that referenced this pull request Dec 16, 2019

Support ALB Advanced Routing rules (hashicorp#8268)

9450d27

Fixes hashicorp#8126

tomaszdudek7 mentioned this pull request Dec 17, 2019

Error: Only one of field, host_header, http_header, http_request_method, path_pattern, query_string or source_ip can be set in a condition block #11323

Closed

houstonj1 mentioned this pull request Dec 17, 2019

Support ALB weighted target groups #10942

Closed

paihu mentioned this pull request Dec 19, 2019

lb_listener_rule not allowing SourceIpConfig with source-ip #8955

Closed

Console32 mentioned this pull request Dec 19, 2019

aws_alb_listener_rule can not be modified when using new coniditions #11362

Closed

brikis98 mentioned this pull request Dec 28, 2019

Chapter 2 - webserver cluster - Terraform warning brikis98/terraform-up-and-running-code#43

Closed

jaspervdj-luminal pushed a commit to LuminalHQ/terraform-provider-aws that referenced this pull request Dec 31, 2019

Support ALB Advanced Routing rules (hashicorp#8268)

ed2b1b2

Fixes hashicorp#8126

bflad mentioned this pull request Jan 6, 2020

ALB weighted target groups #11477

Closed

mwarkentin mentioned this pull request Jan 7, 2020

fix: update deprecated ALB listener rule format terraform-aws-modules/terraform-aws-atlantis#89

Merged

curtis-fugue added a commit to LuminalHQ/terraform-provider-aws that referenced this pull request Jan 13, 2020

Revert "Support ALB Advanced Routing rules (hashicorp#8268)"

ac57b94

This reverts commit ed2b1b2.

ghost locked and limited conversation to collaborators Mar 28, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support ALB Advanced Routing rules #8268

Support ALB Advanced Routing rules #8268

dpiddockcmp commented Apr 10, 2019 •

edited

Loading

cmayne-r7 commented Apr 24, 2019

facundovictor left a comment •

edited

Loading

spider-network commented May 9, 2019

cjgratacos commented May 9, 2019

KellerII commented May 10, 2019

bradpritchard commented May 10, 2019

mvn-bachhuynh-dn commented May 13, 2019 •

edited

Loading

subzero112233 commented May 14, 2019

cemo commented May 21, 2019

bharat109puri commented May 22, 2019

tomaszdudek7 commented May 23, 2019

pasali commented May 27, 2019

dud225 commented May 28, 2019

t0klian commented Jun 5, 2019

c-yokoyama commented Jun 17, 2019

adityaathalye commented Jun 18, 2019

aeschright left a comment

aeschright commented Dec 6, 2019

dpiddockcmp commented Dec 7, 2019

barneyparker commented Dec 7, 2019

dfens1 commented Dec 7, 2019

ArseniiPetrovich commented Dec 9, 2019

bharat109puri commented Dec 9, 2019

sandangel commented Dec 11, 2019

dpiddockcmp commented Dec 11, 2019

ghost commented Dec 13, 2019

ghost commented Mar 28, 2020

Support ALB Advanced Routing rules #8268

Support ALB Advanced Routing rules #8268

Conversation

dpiddockcmp commented Apr 10, 2019 • edited Loading

Community Note

Notes

cmayne-r7 commented Apr 24, 2019

facundovictor left a comment • edited Loading

Choose a reason for hiding this comment

spider-network commented May 9, 2019

cjgratacos commented May 9, 2019

KellerII commented May 10, 2019

bradpritchard commented May 10, 2019

mvn-bachhuynh-dn commented May 13, 2019 • edited Loading

subzero112233 commented May 14, 2019

cemo commented May 21, 2019

bharat109puri commented May 22, 2019

tomaszdudek7 commented May 23, 2019

pasali commented May 27, 2019

dud225 commented May 28, 2019

t0klian commented Jun 5, 2019

c-yokoyama commented Jun 17, 2019

adityaathalye commented Jun 18, 2019

aeschright left a comment

Choose a reason for hiding this comment

aeschright commented Dec 6, 2019

dpiddockcmp commented Dec 7, 2019

barneyparker commented Dec 7, 2019

dfens1 commented Dec 7, 2019

ArseniiPetrovich commented Dec 9, 2019

bharat109puri commented Dec 9, 2019

sandangel commented Dec 11, 2019

dpiddockcmp commented Dec 11, 2019

ghost commented Dec 13, 2019

ghost commented Mar 28, 2020

dpiddockcmp commented Apr 10, 2019 •

edited

Loading

facundovictor left a comment •

edited

Loading

mvn-bachhuynh-dn commented May 13, 2019 •

edited

Loading