Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix aws_autoscaling_group default_cooldown in case explicitly set to 0 #8419

Closed
wants to merge 1 commit into from
Closed

Fix aws_autoscaling_group default_cooldown in case explicitly set to 0 #8419

wants to merge 1 commit into from

Conversation

f3lang
Copy link
Contributor

@f3lang f3lang commented Apr 24, 2019

The GetOk will compare the value to the default zero value of a
type. When the default_cooldown is set to 0, the value matches the default zero
value of the type Integer and will be ignored for the api request.
Normally not a problem, but in this case, this results in an default_cooldown
of 300s on AWS side.
This change will use getOkExists, which doesn't compare to the default zero value.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Fixes #8412

@f3lang
Fix aws_autoscaling_group default_cooldown in case explicitly set to 0
3174908 
The GetOk will compare the value to the default zero value of a
type. When the default_cooldown is set to 0, the value matches the default zero
value of the type Integer and will be ignored for the api request.
Normally not a problem, but in this case, this results in an default_cooldown
of 300s on AWS side.
fixes #8412
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/autoscaling Issues and PRs that pertain to the autoscaling service. labels Apr 24, 2019
@bflad bflad added the bug Addresses a defect in current functionality. label Apr 24, 2019
@aeschright aeschright requested a review from a team June 26, 2019 16:41
@bflad
Copy link
Contributor

bflad commented Aug 7, 2019

Similar note here that we should shy away from an implementation with d.GetOkExists() (#8267 (comment)). We might want to implement a default similar to #9605. We should also add covering acceptance testing if possible. 👍

@nywilken nywilken added the waiting-response Maintainers are waiting on response from community or contributor. label Sep 18, 2019
@nywilken
Copy link
Contributor

hi @f3lang thanks again for this contribution. Please let us know if you would like to continue moving forward with this fix and if you have any questions about the provided feedback.

Cheers!

@bflad
Copy link
Contributor

bflad commented Nov 1, 2019

Closing due to lack of response. Please see #8419 (comment) for additional information about a potential fix in this situation.

@bflad bflad closed this Nov 1, 2019
@ghost
Copy link

ghost commented Mar 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 29, 2020
@breathingdust breathingdust removed the waiting-response Maintainers are waiting on response from community or contributor. label Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. service/autoscaling Issues and PRs that pertain to the autoscaling service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aws_autoscaling_group creation ignores default_cooldown of 0
4 participants
@f3lang @bflad @nywilken @breathingdust