Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AWS Lake Formation service client #9701

Merged
merged 1 commit into from
Aug 14, 2019
Merged

Add AWS Lake Formation service client #9701

merged 1 commit into from
Aug 14, 2019

Conversation

ewbankkit
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #9700.

Add service client for AWS Lake Formation following the Contributing instructions.

Release note for CHANGELOG:

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

@ewbankkit ewbankkit requested a review from a team August 9, 2019 13:56
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. provider Pertains to the provider itself, rather than any interaction with AWS. documentation Introduces or discusses updates to documentation. labels Aug 9, 2019
@ewbankkit
Copy link
Contributor Author

Cannot be completed until #9670 is merged, which requires a fix to the AWS SDK: aws/aws-sdk-go#2741, aws/aws-sdk-go#2742.

@bflad bflad added the upstream Addresses functionality related to the cloud provider. label Aug 9, 2019
@aeschright
Copy link
Contributor

AWS decided on a more general fix, which was just merged: aws/aws-sdk-go#2747

@ewbankkit ewbankkit force-pushed the add-lakeformation-service-client branch from 0aa0df0 to af20897 Compare August 14, 2019 13:52
@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. dependencies Used to indicate dependency changes. and removed size/XS Managed by automation to categorize the size of a PR. labels Aug 14, 2019
@ewbankkit ewbankkit changed the title [WIP] Add AWS Lake Formation service client Add AWS Lake Formation service client Aug 14, 2019
@ewbankkit
Copy link
Contributor Author

Include cb9dc03 from #9670.

@bflad bflad removed the upstream Addresses functionality related to the cloud provider. label Aug 14, 2019
@bflad
Copy link
Contributor

bflad commented Aug 14, 2019

Once this is rebased (just merged v1.23.0 of the AWS Go SDK), we should be able to get this in 👍

@ewbankkit ewbankkit force-pushed the add-lakeformation-service-client branch from af20897 to 6375c0b Compare August 14, 2019 17:44
@ewbankkit
Copy link
Contributor Author

Thanks; rebased.

bflad
bflad approved these changes Aug 14, 2019
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Huzzah, looks great! Thanks, @ewbankkit! 🚀

@bflad bflad added this to the v2.24.0 milestone Aug 14, 2019
@bflad bflad merged commit 96cbdf6 into hashicorp:master Aug 14, 2019
@ewbankkit ewbankkit deleted the add-lakeformation-service-client branch August 15, 2019 12:02
@ghost
Copy link

ghost commented Aug 15, 2019

This has been released in version 2.24.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 1, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
dependencies Used to indicate dependency changes. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. size/XXL Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v2.24.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ewbankkit @aeschright @bflad