azurerm_recovery_services_vault - introduce soft_delete_status

[Klaas-]

introduce soft_delete_status for azurerm_recovery_services_vault

Supersede soft_delete_state (boolean) by soft_delete_status (String)

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

I am trying to fix #23557 , Azure did a bad thing here, it changed a previous boolean value to a something with 4 states. So I think this needs to be addressed in a backwards compatible way by introducing a new attribute for it.

I do have a problem that I have not yet solved, I think within
https:/Klaas-/terraform-provider-azurerm/blob/3227a9bbd9dee25c8b41cfeb10452d5327b69a5a/internal/services/recoveryservices/recovery_services_vault_resource.go#L351-L356
I need to tell tf that the value of soft_delete_status is not the default true but false.

Also I was unsure if I should update all tests to use the new attribute (which I currently did) or if I should write separate tests. Looking for guidance here. I have not yet run the full tests suite because I noticed the problem described above in my manual tests.

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have written new tests for my resource or datasource changes & updated any relevent documentation.
• I have manually run tests, and I noticed problems that I need help with
• (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• azurerm_recovery_services_vault - add soft_delete_status property [GH-00000]

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Fixes #23557

Note

If this PR changes meaningfully during the course of review please update the title and description as required.