BUGFIX: use ListType of ObjectType for Computed attributes instead of Blocks
#246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 25, 2022 14:46
…f `Object`, instead of a blocks' list This is necessary. so that we can express to Terraform that the attribute is indeed `Computed` and it can't be expected to be populated, until the data source is read. This was creating an issue (see #244), as Terraform protocol doesn't support expressing that a Block is Computed: only attributes can be. This approach avoids the use of `NestedAttributes`, and as such is compatible with Protocol v5 (i.e. TF >= 0.12).
…a scenario where "computed certificates are unknown until applied"
bflad
approved these changes
Jul 25, 2022
Co-authored-by: Brian Flad <[email protected]>
detro
deleted the
detro/BUGFIX_224-use_list_of_objects_for_computed_attributes_instead_of_blocks
branch
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #244
Blocks, on a protocol-level, don't support expressing the attribute of beingComputed:terraform-plugin-frameworkdoesn't support it (yet?).But in our case it's possible to just do away with
Blocksfor thetls_certificate.certificates, and instead define an attribute of typeListType, that carries anObjectType. By using an actualAttribute, we can then express the fact that this is aComputedattribute of the data source, and has such it's not expected to have a value until theAPPLY-PHASEof Terraform. That will make the error encountered by practitioners in #224 go away.NOTE: We CANNOT use
Attribute.NestAttributesfor this, as that would break the compatibility with Protocol 5, i.e withTF >= 0.12.