Add support for scopes to terraform login

[jceresini]

Support was previously added in terraform_svchost (hashicorp/terraform-svchost#5)

This PR pulls in that version of terraform_svchost and adds support to terraform to include the scope(s) in the URL generated by terraform login [hostname]

Fixes #25354

[codecov]

Codecov Report

Merging #26239 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted Files	Coverage Δ
command/login.go	51.18% <100.00%> (+0.23%)	⬆️
dag/walk.go	92.54% <0.00%> (-0.63%)	⬇️

[alisdair]

Thanks for working on this, @jceresini! I edited the PR description to link to the relevant issue.

Rereading Martin's comment on the issue, I think there are a couple of steps remaining for this implementation:

• Set the Scopes field when we populate oauth2.Config, so the client will include those in the authorization request.

(This is done)

(Should also do this in the password grant type handler for consistency, even though the only server we allow for that right now doesn't use it.)

TODO

• Add a new permutation to the terraform login tests to verify that the scope passes through correctly when discovery includes it, and is omitted when discovery doesn't include it.

TODO

---

Unless any other issues come up, I think we should be able to merge this once those two things are addressed. Hope that makes sense!

[jceresini]

@alisdair I believe that is now addressed. I made separate tests for validating that the scopes made it to the disco.OAuthClient because I thought that would be easier to understand.

[alisdair]

Thanks! 🎉

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.