command: Taint should respect required_version #26345
Conversation
Despite not requiring the configuration for any other reason, the taint subcommand should not execute if the required_version constraints cannot be met. Doing so can result in an undesirable state file upgrade.
Codecov Report
|
| @@ -62,6 +64,34 @@ func (c *TaintCommand) Run(args []string) int { | |||
| return 1 | |||
| } | |||
|
|
|||
| // Load the config and check the core version requirements are satisfied | |||
There was a problem hiding this comment.
I'm not sure, but I'd be curious to see if the earlyconfig loader (examples in init.go) is sufficient and perhaps faster for this purpose. loadSingleModule for e.g. will only load the root module:
terraform/command/meta_config.go
Lines 95 to 97 in 6d86cd4
Again, this might not actually be faster or better, but it might be worth looking at.
There was a problem hiding this comment.
Ah, I hadn't thought of that! Unfortunately I think we need to load and check the entire tree's version constraints. In particular, many public registry modules have fairly strict version requirements that we need to honour.
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked as resolved and limited conversation to collaborators
Despite not requiring the configuration for any other reason, the taint subcommand should not execute if the required_version constraints cannot be met. Doing so can result in an undesirable state file upgrade.
Fixes #26325. Fixes #23049.
Question for reviewers: it feels to me like there ought to be a neater way of loading the config to check the constraints are met. Can you think of one? 🙏