Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of cli: Fix rendering of long integers into v0.14 #27479

Conversation

teamterraform
Copy link
Contributor

Backport

This PR is auto-generated from #27440 to be assessed for backporting due to the inclusion of the label 0.14-backport.

The below text is copied from the body of the original PR.


Recent changes to the human-readable rendering of outputs and console values led to long integer values being presented in scientific notation (e.g. 1.2345678e+07). While technically correct, this is an unusual way to present integer values.

This commit checks if a number value is an integer, and if so renders it as a sequence of digits instead (e.g. 12345678).

Fixes #27438.

@teamterraform teamterraform force-pushed the backport/alisdair/fix-rendering-of-long-integers/immensely-magnetic-buffalo branch from f3f90f9 to 659f588 Compare January 12, 2021 15:07
@codecov
Copy link

codecov bot commented Jan 12, 2021

Codecov Report

Merging #27479 (f9931df) into v0.14 (eed411e) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted Files Coverage Δ
repl/format.go 99.05% <100.00%> (ø)
dag/marshal.go 53.42% <0.00%> (-1.37%) ⬇️

@alisdair alisdair merged commit 503e78c into v0.14 Jan 12, 2021
@alisdair alisdair deleted the backport/alisdair/fix-rendering-of-long-integers/immensely-magnetic-buffalo branch January 12, 2021 16:12
@ghost
Copy link

ghost commented Feb 12, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked as resolved and limited conversation to collaborators Feb 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants