Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit ProviderAlreadyInstalled when provider installed #27722

Merged
merged 1 commit into from
Feb 10, 2021

Conversation

pselle
Copy link
Contributor

@pselle pselle commented Feb 9, 2021

Emit the ProviderAlreadyInstalled event when we successfully verify that we've already installed this provider and are skipping installation.

Before:

$ terraform init

Initializing the backend...

Initializing provider plugins...
- Reusing previous version of providerland/foo from the dependency lock file

Terraform has been successfully initialized!

After:

$ terraform init

Initializing the backend...

Initializing provider plugins...
- Reusing previous version of providerland/foo from the dependency lock file
- Using previously-installed providerland/foo v0.0.8

Terraform has been successfully initialized!

Emit the ProviderAlreadyInstalled event when we successfully verify
that we've already installed this provider and are skipping
installation
@codecov
Copy link

codecov bot commented Feb 9, 2021

Codecov Report

Merging #27722 (aa24bfe) into master (96be094) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted Files Coverage Δ
internal/providercache/installer.go 68.54% <100.00%> (+0.29%) ⬆️

@pselle pselle requested a review from a team February 9, 2021 16:16
@pselle pselle added the 0.14-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged label Feb 10, 2021
@pselle pselle merged commit 0a99757 into master Feb 10, 2021
@pselle pselle deleted the pselle/init-installed branch February 10, 2021 15:02
@ghost
Copy link

ghost commented Mar 13, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked as resolved and limited conversation to collaborators Mar 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
0.14-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants