Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resolution message for S3/DynamoDB state checksum mismatch #34387

Merged
merged 3 commits into from
Mar 26, 2024

Conversation

mschfh
Copy link
Contributor

@mschfh mschfh commented Dec 9, 2023

The current resolution message incorrectly suggests updating the DynamoDB value to the value already stored there, rather than to the calculated checksum of the S3 state file.

Draft CHANGELOG entry

BUG FIXES

  • Fixed the digest value displayed for DynamoDB/S3 state checksum mismatches.

@mschfh mschfh requested a review from a team as a code owner December 9, 2023 03:35
@hashicorp-cla
Copy link

hashicorp-cla commented Dec 9, 2023

CLA assistant check
All committers have signed the CLA.

@mschfh
Copy link
Contributor Author

mschfh commented Jan 17, 2024

@jbardin Could someone please review this?

@crw
Copy link
Collaborator

crw commented Jan 17, 2024

Apologies, somehow I missed this (GitHub notifications seem to be a little flaky). I've notified the AWS provider team.

@mschfh
Copy link
Contributor Author

mschfh commented Mar 22, 2024

@crw Thanks. Is there any update yet, I can't see any reviewers assigned to the PR?

@crw
Copy link
Collaborator

crw commented Mar 26, 2024

It has not been picked up yet for review. I can see this on their project board, so it is basically backlogged at the moment. I'll check in with them.

Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% TF_ACC=1 go test ./...

ok      github.com/hashicorp/terraform/internal/backend/remote-state/s3 146.752s

@jar-b jar-b added the 1.8-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged label Mar 26, 2024
@jar-b
Copy link
Member

jar-b commented Mar 26, 2024

Thanks for your contribution, @mschfh! 👍

@jar-b jar-b merged commit 628b894 into hashicorp:main Mar 26, 2024
5 of 6 checks passed
Copy link

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1.8-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged backend/s3 enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants