Missing import target in module should error #35330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When grouping imports by module for validation, imports with no associated module were left out and would silently fail. Change the config transformer to check all import targets together to make sure they are all valid within a configuration.
jbardin
added
the
1.9-backport
liamcervante
approved these changes
Jun 12, 2024
|
Merging and backporting now, to make sure it lands in 1.9.0, as it could result in a behavioral change if a configuration has existing invalid import blocks. |
|
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
jbardin
added a commit
that referenced
this pull request
Jun 12, 2024
backport #35330: Missing import target in module should error
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When grouping imports by module for validation, imports with no associated module were left out and would silently fail. Change the config transformer to check all import targets together to make sure they are all valid within a configuration.
Fixes #35303