provider/aws: aws_vpn_gateway_route_propagation resource

[apparentlymart]

This is a separate resource that serves a similar purpose to the propagating_vgws argument on aws_route_table, but allows route propagations to be created independently of the route table, which in
turn allows the VPN gateway to be created after the route table it will contribute to, possibly in a separate Terraform module.

To make this work, propagating_vgws on aws_route_table is now marked as Computed, meaning that it won't try to delete any existing propagation edges if there is no setting for it in configuration at all. This allows the user to choose whether to use the argument or the separate resource, though using both together will not work, as explained in the docs.

This is a slight change in existing behavior, because previously the aws_route_table resource would actively remove any existing route propagation relationships if the argument was not set in config.

This fixes #3424.

[stack72]

@apparentlymart, LGTM - made 1 change locally which was to fix a vet issue (figured you have your hands full with 0.10.0)

% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSRouteTable_'                                                            ✭
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/06/09 13:51:42 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSRouteTable_ -timeout 120m
=== RUN   TestAccAWSRouteTable_importBasic
--- PASS: TestAccAWSRouteTable_importBasic (77.74s)
=== RUN   TestAccAWSRouteTable_complex
--- PASS: TestAccAWSRouteTable_complex (217.96s)
=== RUN   TestAccAWSRouteTable_basic
--- PASS: TestAccAWSRouteTable_basic (120.01s)
=== RUN   TestAccAWSRouteTable_instance
--- PASS: TestAccAWSRouteTable_instance (183.13s)
=== RUN   TestAccAWSRouteTable_ipv6
--- PASS: TestAccAWSRouteTable_ipv6 (61.81s)
=== RUN   TestAccAWSRouteTable_tags
--- PASS: TestAccAWSRouteTable_tags (163.68s)
=== RUN   TestAccAWSRouteTable_panicEmptyRoute
--- PASS: TestAccAWSRouteTable_panicEmptyRoute (37.75s)
=== RUN   TestAccAWSRouteTable_vpcPeering
--- PASS: TestAccAWSRouteTable_vpcPeering (70.17s)
=== RUN   TestAccAWSRouteTable_vgwRoutePropagation
--- PASS: TestAccAWSRouteTable_vgwRoutePropagation (80.28s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/aws	1012.574s
[stacko@Pauls-MacBook-Pro:~/Code/go/src/github.com/hashicorp/terraform on gh3424-vgw-route-prop]
% make testacc TEST=./builtin/providers/aws TESTARGS='-run=TestAccAWSVPNGatewayRoutePropagation'                                           ✹ ✭
==> Checking that code complies with gofmt requirements...
go generate $(go list ./... | grep -v /terraform/vendor/)
2017/06/09 14:10:03 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/aws -v -run=TestAccAWSVPNGatewayRoutePropagation -timeout 120m
=== RUN   TestAccAWSVPNGatewayRoutePropagation_basic
--- PASS: TestAccAWSVPNGatewayRoutePropagation_basic (76.74s)
PASS
ok  	github.com/hashicorp/terraform/builtin/providers/aws	76.777s

[apparentlymart]

Thanks for the fix, and the merge! 😀

[nwhite-dw]

I could use this new resource, has it been released?

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.