Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating import usage doc with accurate example of complex import with secondary resources #24525

Merged
merged 1 commit into from
Apr 8, 2020

Conversation

spavuluri
Copy link
Contributor

This pull request has no code change but only contains documentation update resulting from changes proposed to the terraform-provider-aws.

Reason for Change

terraform-provider-aws pull request contains changes that alter behavior of AWS security group such that import of aws_security_group will no longer implicitly import aws_security_group_rule for associated rules.

This change, therefore, removes mention of aws_security_group and replaces with example of aws_network_acl that exhibits such complex import behavior discussed in the doc.

…ork_acl as an example of complex import involving secondary resources
@hashicorp-cla
Copy link

hashicorp-cla commented Apr 1, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@nfagerlund nfagerlund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine, and since it's already accurate, it probably doesn't need to be gated on the functionality change being merged. I'm gonna go ahead and merge it so we don't have to continue tracking it.

@nfagerlund nfagerlund merged commit a0832b9 into hashicorp:master Apr 8, 2020
@ghost
Copy link

ghost commented May 8, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators May 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants