Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs and add warning for -get-plugins #27169

Merged
merged 1 commit into from
Dec 7, 2020
Merged

Conversation

pselle
Copy link
Contributor

@pselle pselle commented Dec 7, 2020

As of Terraform 0.13+, the get-plugins command has been superseded by new provider installation mechanisms, and general philosophy (providers are always installed, but the sources may be customized). Update the init command to give users a warning if they are setting this flag, to encourage them to remove it from their workflow, and update relevant docs and docstrings as well.

Fixes #27092

Looking to backport to 0.14 (which would give 0.14.1+ users a warning when using this flag), and remove the flag completely in 0.15 after this.

Also looking for:

  • Are the reccs here the preferred recommendations for people using this flag?
  • Approval/Nay-saying on the "add a warning, then remove completely" plan
  • Should this be backported to 0.13 as well?

@codecov
Copy link

codecov bot commented Dec 7, 2020

Codecov Report

Merging #27169 (b963ea8) into master (bedc08f) will increase coverage by 0.00%.
The diff coverage is 53.84%.

Impacted Files Coverage Δ
command/init.go 62.39% <53.84%> (-0.39%) ⬇️
terraform/evaluate.go 52.89% <0.00%> (-0.42%) ⬇️
dag/marshal.go 63.49% <0.00%> (+1.58%) ⬆️
internal/providercache/dir.go 73.46% <0.00%> (+6.12%) ⬆️

@pselle pselle requested a review from a team December 7, 2020 16:22
@pselle pselle added the 0.14-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged label Dec 7, 2020
@pkolyvas
Copy link
Contributor

pkolyvas commented Dec 7, 2020

Speaking only to the documentation and UX guidance, this looks great to me. I agree with back porting this to give our community even more heads up - especially since we're planning a final 0.13 release.

Copy link
Contributor

@mildwonkey mildwonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the warning in 0.14 (and 0.13, if we will have more 0.13 releases)/ removal in 0.15 plan!

@pselle pselle added the 0.13-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged label Dec 7, 2020
As of Terraform 0.13+, the get-plugins command has been
superceded by new provider installation mechanisms, and
general philosophy (providers are always installed, but
the sources may be customized). Updat the init command
to give users a warning if they are setting this flag,
to encourage them to remove it from their workflow, and
update relevant docs and docstrings as well
@ghost
Copy link

ghost commented Jan 7, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked as resolved and limited conversation to collaborators Jan 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
0.13-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged 0.14-backport If you add this label to a PR before merging, backport-assistant will open a new PR once merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terraform Init -get-plugins=false does not fail as expect in 0.13.x and beyond.
3 participants