Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle move blocks within a module which is changing the index #30232

Merged
merged 3 commits into from
Dec 22, 2021

Commits on Dec 21, 2021

  1. IsModuleMoveReIndex

    Add a method for checking if the From and To addresses in a move
    statement are only changing the indexes of modules relative to the
    statement module.
    
    This is needed because move statement nested within the module will be
    able to match against both the From and To addresses, causing cycles in
    the order of move operations.
    jbardin committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    346418e View commit details
    Browse the repository at this point in the history
  2. find implied moves in nested modules

    Implied moves in nested modules were being skipped
    jbardin committed Dec 21, 2021
    Configuration menu
    Copy the full SHA
    e761117 View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2021

  1. check for nested module index changes

    Changing only the index on a nested module will cause all nested moves
    to create cycles, since their full addresses will match both the From
    and To addresses. When building the dependency graph, check if the
    parent is only changing the index of the containing module, and prevent
    the backwards edge for the move.
    jbardin committed Dec 22, 2021
    Configuration menu
    Copy the full SHA
    75ef61c View commit details
    Browse the repository at this point in the history