-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make file name convention list more readable #35315
Open
cadamini
wants to merge
2
commits into
hashicorp:main
Choose a base branch
from
cadamini:patch-3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cadamini
commented
Jun 9, 2024
cadamini
commented
Jun 9, 2024
Comment on lines
+105
to
+107
- A `network.tf`: VPC, subnets, load balancers, and all other networking resources. | ||
- A `storage.tf`: Object storage and related permissions configuration. | ||
- A `compute.tf`: Compute instances. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
- A `network.tf`: VPC, subnets, load balancers, and all other networking resources. | |
- A `storage.tf`: Object storage and related permissions configuration. | |
- A `compute.tf`: Compute instances. | |
- A `network.tf`: VPC, subnets, load balancers, and all other networking resources | |
- A `storage.tf`: Object storage and related permissions configuration | |
- A `compute.tf`: Compute instances |
periods required?
cadamini
commented
Jun 9, 2024
Comment on lines
+94
to
+101
- `backend.tf`: Your [backend configuration](/terraform/language/settings/backends/configuration). You can define multiple `terraform` blocks in your configuration to separate your backend configuration from your Terraform and provider versioning configuration. | ||
- `main.tf`: Resource and data source blocks. | ||
- `outputs.tf`: Output blocks in alphabetical order. | ||
- `providers.tf`: Your `provider` blocks and configuration. | ||
- `terraform.tf`: A single `terraform` block which defines your `required_version` and `required_providers`. | ||
- `variables.tf`: Variable blocks in alphabetical order. | ||
- `locals.tf`: Local values. Refer to [local values](#local-values) for more information. | ||
- `override.tf`: Override definitions for your configuration. Terraform loads this and all files ending with `_override.tf` last. Use them sparingly and add comments to the original resource definitions, as these overrides make your code harder to reason about. Refer to the [override files](/terraform/language/files/override) documentation for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
- `backend.tf`: Your [backend configuration](/terraform/language/settings/backends/configuration). You can define multiple `terraform` blocks in your configuration to separate your backend configuration from your Terraform and provider versioning configuration. | |
- `main.tf`: Resource and data source blocks. | |
- `outputs.tf`: Output blocks in alphabetical order. | |
- `providers.tf`: Your `provider` blocks and configuration. | |
- `terraform.tf`: A single `terraform` block which defines your `required_version` and `required_providers`. | |
- `variables.tf`: Variable blocks in alphabetical order. | |
- `locals.tf`: Local values. Refer to [local values](#local-values) for more information. | |
- `override.tf`: Override definitions for your configuration. Terraform loads this and all files ending with `_override.tf` last. Use them sparingly and add comments to the original resource definitions, as these overrides make your code harder to reason about. Refer to the [override files](/terraform/language/files/override) documentation for more information. | |
- `backend.tf`: Your [backend configuration](/terraform/language/settings/backends/configuration). You can define multiple `terraform` blocks in your configuration to separate your backend configuration from your Terraform and provider versioning configuration. | |
- `main.tf`: Resource and data source blocks | |
- `outputs.tf`: Output blocks in alphabetical order | |
- `providers.tf`: Your `provider` blocks and configuration | |
- `terraform.tf`: A single `terraform` block which defines your `required_version` and `required_providers` | |
- `variables.tf`: Variable blocks in alphabetical order | |
- `locals.tf`: Local values. Refer to [local values](#local-values) for more information. | |
- `override.tf`: Override definitions for your configuration. Terraform loads this and all files ending with `_override.tf` last. Use them sparingly and add comments to the original resource definitions, as these overrides make your code harder to reason about. Refer to the [override files](/terraform/language/files/override) documentation for more information. |
periods required for incomplete sentences?
Thanks for the submission. Passing to the docs team for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just stumbled over this list while reading. I think the verb doesn't need to be repeated.