Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terraform: Error message for unknown error_message in variable validation [v1.9 backport] #35449

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

apparentlymart
Copy link
Contributor

This is a backport of #35400 to the v1.9 branch.

I had intended to use the normal backport process but I forgot to add the label before I merged, so here we are. 🤷‍♂️

This was just a direct cherry-pick with no conflicts.

…tion

In cases where the "condition" is known but the "error_message" is not,
we were previously returning the generic error about the error message
not being evaluable.

In the long run we'll want to do something better here to minimize the
chances of this situation arising -- reporting an error that we don't
know how to describe is a poor user experience -- but this is a temporary
intervention to at least make the error message more relevant in the
meantime, while we design how Terraform actually ought to behave in this
awkward situation.
@apparentlymart apparentlymart requested a review from a team July 11, 2024 20:42
@apparentlymart apparentlymart self-assigned this Jul 11, 2024
@apparentlymart apparentlymart merged commit 0216ed8 into v1.9 Jul 12, 2024
10 checks passed
@apparentlymart apparentlymart deleted the f-validation-unknown-errmsg-v1.9 branch July 12, 2024 16:01
Copy link

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants