Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update mirage readme instructions #28673

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Update mirage readme instructions #28673

merged 1 commit into from
Oct 10, 2024
+4 −1

Conversation

Monkeychip
Copy link
Contributor

Description

Updating Mirage readme to clarify a few points of confusion.

@Monkeychip Monkeychip added this to the 1.19.0-rc milestone Oct 10, 2024
@Monkeychip Monkeychip requested a review from a team as a code owner October 10, 2024 16:50
@github-actions github-actions bot added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Oct 10, 2024
@github-actions GitHub Actions
Copy link

Build Results:
All builds succeeded! ✅

@github-actions GitHub Actions
Copy link

CI Results:
All Go tests succeeded! ✅

@Monkeychip Monkeychip merged commit 82133e7 into main Oct 10, 2024
43 checks passed
@Monkeychip Monkeychip deleted the ui/update-mirage-readme branch October 10, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hellobontempo hellobontempo hellobontempo approved these changes

Assignees
No one assigned
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed pr/no-changelog ui
Projects
None yet
Milestone
1.19.0-rc
Development

Successfully merging this pull request may close these issues.
2 participants
@Monkeychip @hellobontempo