OwnSource setting lost after ghcup config add-release-channel

[ksqsf]

Suppose I have the following config,

url-source:
  OwnSource: xxx

Then run the following command,

ghcup config add-release-channel yyy

Now the OwnSource entry disappears,

url-source:
  AddSource:
  - Right: yyy

Consequently, the "main" source will not be xxx, but the default one.

[ksqsf]

ghcup-hs/app/ghcup/GHCup/OptParse/Config.hs

Line 189 in 8234589

doConfig (defaultUserSettings { uUrlSource = Just $ AddSource (xs <> [Right uri]) })

It seems that add-release-channel just adds the new release channel to the default config.

Just to be sure: is this intentional? If so, please close this issue. :-)

[hasufell]

It's a recent feature. I'm willing to make it more robust. PRs also welcome.

The type is here:

ghcup-hs/lib/GHCup/Types.hs

Lines 290 to 294 in 8234589

	data URLSource = GHCupURL
	| OwnSource [Either GHCupInfo URI] -- ^ complete source list
	| OwnSpec GHCupInfo
	| AddSource [Either GHCupInfo URI] -- ^ merge with GHCupURL
	deriving (GHC.Generic, Show)

So OwnSource accepts a list and we could just append to it. OwnSpec could be turned into OwnSource. I've just kept it for backwards compatibility in fact.