Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2020-09 monthly release #449

Closed
alanz opened this issue Oct 1, 2020 · 11 comments
Closed

2020-09 monthly release #449

alanz opened this issue Oct 1, 2020 · 11 comments
Assignees
Labels
old_type: meta Planing and organizing other issues

Comments

@alanz
Copy link
Collaborator

alanz commented Oct 1, 2020

By our monthly cadence we should be aiming to get a release out by the weekend sometime.

What must we wait for before doing it?

I am happy to do it as a non-hackage one, it is more about getting something tagged that we are all comfortable with, given the number of downstreams that package it now

@fendor
Copy link
Collaborator

fendor commented Oct 1, 2020

I have nothing we need to wait for.

We definitely should have a tagged release for ghcup/vscode, regardless of hackage.

BTW, what generates the artifacts on the release page? Is it automatic or manual? We must not forget to add tar archives for all supported HLS versions per platform for ghcup, see #239 (comment).

@jneira
Copy link
Member

jneira commented Oct 1, 2020

what generates the artifacts on the release page? Is it automatic or manual?

automatic with github actions triggered by the release

@fendor
Copy link
Collaborator

fendor commented Oct 1, 2020

Then we need to add this artifact as well

@jneira jneira added the old_type: meta Planing and organizing other issues label Oct 2, 2020
@lukel97
Copy link
Collaborator

lukel97 commented Oct 2, 2020

We can/should probably automate this. I think we can create another GitHub job to run after all the build jobs are done, download the linux/macOS binaries and tar them?

@alanz
Copy link
Collaborator Author

alanz commented Oct 2, 2020

@bubba I was thinking about it, we need to get the whole process automated, there are now so many pieces to be coordinated.

@lukel97
Copy link
Collaborator

lukel97 commented Oct 2, 2020

I think we should be able to use https:/actions/download-artifact for this. Giving it a shot now

@alanz
Copy link
Collaborator Author

alanz commented Oct 2, 2020

See #444 (comment)

@jneira
Copy link
Member

jneira commented Oct 4, 2020

@bubba i would mention the new implicit cradle in the release, cause it theoretically could break some setups.

@lukel97
Copy link
Collaborator

lukel97 commented Oct 4, 2020

@jneira updated the release notes to mention it here https:/haskell/haskell-language-server/releases/tag/0.5.0, does this seem good?

@jneira
Copy link
Member

jneira commented Oct 4, 2020

@bubba 👍 , btw great work with the release

@lukel97
Copy link
Collaborator

lukel97 commented Oct 4, 2020

0.5.0 has been released

@lukel97 lukel97 closed this as completed Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
old_type: meta Planing and organizing other issues
Projects
None yet
Development

No branches or pull requests

6 participants