Keep plugin id of cabal-fmt in sync with default config id #3615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add documentation to note that these values are to be kept in sync
VeryMilkyJoe
force-pushed
the
fix-cabal-fmt
branch
from
127c59b
to
c3c5d2b
Compare
fendor
approved these changes
May 30, 2023
|
Could we do this with an actual type somehow? |
|
How? PluginIds are strings, and the formatting providers have been strings so far... I don't see how we can do that, without killing the Default instance or hard-coding the plugin ID of a plugin in hls-plugin-api. |
|
Argh yes, it's in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add documentation to note that these values are to be kept in sync
Fixes #3613