Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split pragmas plugin by providers + decrease disable-warning priority #3640

Merged
merged 2 commits into from
Jun 12, 2023
Merged

Split pragmas plugin by providers + decrease disable-warning priority #3640

merged 2 commits into from
Jun 12, 2023

Conversation

mrcjkb
Copy link
Contributor

@mrcjkb mrcjkb commented Jun 10, 2023

Fixes #3636.

@mrcjkb mrcjkb marked this pull request as draft June 10, 2023 15:03
@mrcjkb mrcjkb force-pushed the mj/3636-disable-warning-codeaction branch from 1508adf to 756601d Compare June 10, 2023 15:13
@mrcjkb mrcjkb force-pushed the mj/3636-disable-warning-codeaction branch from 756601d to 4524262 Compare June 11, 2023 06:51
@mrcjkb
Copy link
Contributor Author

mrcjkb commented Jun 11, 2023

The current test suite is fixed.

I guess it would be nice to have a test that verifies that the "disable this warning" action appears last, but that would be outside the scope of the hls-pragmas-plugin test, since this would have to be tested with multiple plugins.

@mrcjkb mrcjkb marked this pull request as ready for review June 11, 2023 06:54
@mrcjkb mrcjkb force-pushed the mj/3636-disable-warning-codeaction branch from 4524262 to 7a6bc37 Compare June 11, 2023 06:55
@mrcjkb mrcjkb requested a review from fendor June 11, 2023 06:55
@mrcjkb mrcjkb force-pushed the mj/3636-disable-warning-codeaction branch from 7a6bc37 to 0381290 Compare June 11, 2023 10:26
@mrcjkb mrcjkb mentioned this pull request Jun 11, 2023
Open
@mrcjkb mrcjkb force-pushed the mj/3636-disable-warning-codeaction branch from 0381290 to 746f7ea Compare June 11, 2023 13:42
@fendor fendor added the merge me Label to trigger pull request merge label Jun 12, 2023
@mergify mergify bot merged commit 6ff0e02 into haskell:master Jun 12, 2023
@mrcjkb mrcjkb deleted the mj/3636-disable-warning-codeaction branch June 12, 2023 16:00
@fendor fendor mentioned this pull request Aug 8, 2023
Merged
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fendor fendor fendor approved these changes

@berberman berberman Awaiting requested review from berberman

@Ailrun Ailrun Awaiting requested review from Ailrun

@eddiemundo eddiemundo Awaiting requested review from eddiemundo eddiemundo is a code owner

Assignees
No one assigned
Labels
merge me Label to trigger pull request merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

codeAction "Disable <foo-bar> warnings" is the first suggestion
2 participants
@mrcjkb @fendor