Re-add hls-stan-plugin #3851
Re-add hls-stan-plugin #3851
Conversation
cabal.project
Outdated
| ./plugins/hls-gadt-plugin | ||
| ./plugins/hls-explicit-fixity-plugin | ||
| ./plugins/hls-explicit-record-fields-plugin | ||
| ./plugins/hls-refactor-plugin | ||
| ./plugins/hls-overloaded-record-dot-plugin | ||
|
|
||
| index-state: 2023-10-06T06:12:29Z | ||
| -- index-state: 2023-10-06T06:12:29Z |
There was a problem hiding this comment.
I commented out the index-state to get the new stan version.
There was a problem hiding this comment.
You should just update the index-state. No point in commenting it out and the PR can't be merged without it any way.
There was a problem hiding this comment.
While it is great to have stan back, perhaps even with new diagnostics, we lack a maintainer for the plugin. Are you volunteering to maintain the stan plugin in the foreseeable future? If so, please add yourself to the CODEOWNERS file.
Since we do experience some issues with plugins that bitrot because it has no active maintainer, I don't think we will merge this until we have found a maintainer.
|
Maybe i could do it. What is expected of a maintainer? I suppose mainly keep it running with ghc changes and fix bug reports? |
|
Exactly, and you will mainly be pinged in the case of hls-stan-plugin related issues, but it does not include fixing the bug upstream in stan. |
Fix ghc bounds for stan plugin Update index-state
|
Ok. I will mantain the plugin, I've added myself to the |
|
I wonder if @tomjaguarpaw would also be interested in being involved? |
|
Hi, thanks for pinging me. I don't have the bandwidth to be a maintainer of the plugin myself, but I'm happy to unblock any issues that need help on the upstream |
|
@0rphee You received an invitation to this repo! Once you have accepted, we will merge this PR :) Thank you for your patience! |
|
(and please fix the conflicts) |
|
I've accepted the invitation to the repo :) The conflicts are fixed. From what I've seen, the stack lts21 previous build failure was caused by a now fixed issue (#3868). Also, I now remembered about the hls-stan-plugin test suite (I forgot to add it to the gh actions workflow), should I still add it back? |
🎊
Ah, yes please, add it back to the GitHub actions. Otherwise, we won't run the test suite in CI! |
|
I think everything is fine now! |
|
This is great to see! Thanks @0rphee. |
Hi! now that stan supports ghc-9.6 (kowainik/stan#523), I figured that it would be possible to add its hls plugin back.
I tested it locally with 9.6.3.
9.8.1 support for the stan plugin tests requires to add
th-abstractiontoallow-newerincabal.project, and depends on the publishing of 9.8.1 support to hackage forhiedb. (They are indirect dependencies, I'm not sure which dependency might trigger them, I'm not used to cabal)If something more is needed, please tell me and I'll see what I can do :)