Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make vscode-extension-schema honour default values #3925

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

fendor
Copy link
Collaborator

@fendor fendor commented Jan 4, 2024

Follow up to #3917, where the command hls vscode-extension-schema did not to honour the default values of the plugin description.

The first commit of this PR fixes that shortcoming.
The second commit unifies the plugin config generation. I am not sure whether that's a good idea, as I feel it obfuscates the code more. I am leaving it in for discussion, but I am completely open to dropping the second commit.

@fendor
Copy link
Collaborator Author

fendor commented Jan 4, 2024

This is likely easier to review once #3922 is merged

@fendor fendor force-pushed the enhance/vscode-exts-def-vals branch 3 times, most recently from 496ac01 to 506b41e Compare January 5, 2024 11:47
@fendor
Copy link
Collaborator Author

fendor commented Jan 5, 2024

I decided to drop the unification of the code paths, as the subtle differences made it unnecessarily difficult.

Copy link
Collaborator

@joyfulmantis joyfulmantis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michaelpj
Copy link
Collaborator

has conflicts

@fendor fendor force-pushed the enhance/vscode-exts-def-vals branch from 506b41e to 0b2c405 Compare January 9, 2024 10:24
@fendor fendor enabled auto-merge January 9, 2024 10:27
@fendor fendor added the merge me Label to trigger pull request merge label Jan 9, 2024
@soulomoon
Copy link
Collaborator

           "haskell.plugin.semanticTokens.globalOn": {
      -        "default": true,
      +        "default": false,
               "description": "Enables semanticTokens plugin",
               "scope": "resource",
               "type": "boolean"

the newly added semanticTokens should be false by default.

@fendor fendor removed the merge me Label to trigger pull request merge label Jan 10, 2024
@fendor fendor force-pushed the enhance/vscode-exts-def-vals branch from e8cedf1 to 4b01eb0 Compare January 10, 2024 09:02
@fendor fendor added the merge me Label to trigger pull request merge label Jan 10, 2024
@fendor fendor merged commit ade0e85 into haskell:master Jan 10, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge me Label to trigger pull request merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants