Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #3927
hls-floskell-plugin
updated tofloskell
0.11.* . The reason is thatfloskell
0.11.* supportsaeson
2.2.* : https://hackage.haskell.org/package/floskell-0.11.0There is a small change required in
plugins/hls-floskell-plugin/src/Ide/Plugin/Floskell.hs
. The easy change breaks compatibility withfloskell
0.10. So I have bumped the version ofhls-floskell-plugin
from2.5.0.0
to2.5.1.0
.haskell-language-server
2.5.0.0 is pinned tohls-floskell-plugin
2.5.0.0 exactly. This PR changes the bound onhls-floskell-plugin
to2.5.*
.haskell-language-server
2.5.0.0haskell-language-server
2.5.0.1.haskell-language-server
2.5.0.1 is compatible with both:hls-floskell-plugin
2.5.0.0 andfloskell
0.10.*hls-floskell-plugin
2.5.1.0 andfloskell
0.11.*What do you think?
I suppose this PR should target the tag
2.5.0.0
https:/haskell/haskell-language-server/tree/2.5.0.0 instead ofmaster
First test
git reset
tomaster
. Apply only the change tohaskell-language-server.cabal
. Buildhaskell-language-server
2.5.0.1 and all other packages.This builds successfully:
Second test
In this PR, this builds successfully:
These tests were run in the
nix develop
shell.