Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove an allow-newer #3989

Merged
merged 3 commits into from
Jan 20, 2024
Merged

Remove an allow-newer #3989

merged 3 commits into from
Jan 20, 2024

Conversation

michaelpj
Copy link
Collaborator

No description provided.

@michaelpj
Copy link
Collaborator Author

Hmm, I bumped nixpkgs and now it needs too new a glibc for the GHA runners or something?

@fendor
Copy link
Collaborator

fendor commented Jan 20, 2024

Now we don't test the nix environment any more? That's not ideal, I think the nix environments are useful and we should maintain them.

The GHA runners are quite annoying at times 😅

@michaelpj
Copy link
Collaborator Author

It still tests that the nix environment builds. I don't know. GLIBC issues really suck and I'm not sure there's an easy solution. This is AFAIK the only way to get a dev shell setup with 9.8, for example 🤷

Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change itself looks good.

Let's hope someone who cares about the nix setup will eventually fix it.

@michaelpj michaelpj merged commit 456a0eb into master Jan 20, 2024
25 of 28 checks passed
josephsumabat pushed a commit to josephsumabat/haskell-language-server that referenced this pull request Jan 22, 2024
* Remove an allow-newer

* Cut down the nix workflow more
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants