Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use relative file paths for HIE files and Stan's config maps #4023

Merged
merged 13 commits into from
Feb 2, 2024

Commits on Jan 28, 2024

  1. Use relative file paths for HIE files and Stan's config maps

    Stan expects relative paths. Without this change, file names won't map
    correctly to their associated language extension data, which means no
    enabled extensions will be detected. This causes annoying false
    positives with, e.g., the `StrictData` extension. (See issue haskell#3174.)
    keithfancher committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    9509b27 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2024

  1. Un-exclude Stan diagnostics related to StrictData

    We specifically want to test this diagnostic, so we need it to fire.
    keithfancher committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    4e95308 View commit details
    Browse the repository at this point in the history
  2. Add tests to ensure the Stan plugin detects a module's language exten…

    …sions
    
    Includes test cases for both `LANGUAGE` pragmas and extensions enabled
    in a project's `.cabal` file.
    keithfancher committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    802b46c View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2024

  1. Tighten up Stan plugin language extension test cases

    These changes ensure that the tests will fail given bad mappings in
    either the `cabalExtensionsMap` OR the `checksMap`. Either of these
    could cause bad behavior as seen in issue haskell#3174.
    keithfancher committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    c0dac2e View commit details
    Browse the repository at this point in the history
  2. Use correct extension/file mappings even in the case of a config fiasco

    The Stan plugin will still operate as expected even if we can't load a
    config -- it will simply default to showing all inspections.
    keithfancher committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    e6a8520 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2024

  1. Configuration menu
    Copy the full SHA
    430c82d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    36e8877 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    afa2b9b View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2024

  1. Configuration menu
    Copy the full SHA
    188c767 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d028cd6 View commit details
    Browse the repository at this point in the history
  3. Run stylish-haskell

    keithfancher committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    fc2aff0 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    1c5e034 View commit details
    Browse the repository at this point in the history
  5. Ensure hs-source-dirs in test cabal files don't contain path separa…

    …tors
    
     Related to (what I assume is) a bug in Stan, or its `extensions`
     library. Regardless of OS, the `hs-source-dirs` field is prepended
     as-is to the module name to create the file paths used in the cabal
     extensions map. This means the maps won't work in Windows if your cabal
     file contains `/` path separators. Working around the limitation here
     to ensure tests work on all platforms.
    keithfancher committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    c24f564 View commit details
    Browse the repository at this point in the history