-
-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use relative file paths for HIE files and Stan's config maps #4023
Merged
mergify
merged 13 commits into
haskell:master
from
keithfancher:fix-stan-language-extensions
Feb 2, 2024
Merged
Use relative file paths for HIE files and Stan's config maps #4023
mergify
merged 13 commits into
haskell:master
from
keithfancher:fix-stan-language-extensions
Feb 2, 2024
Commits on Jan 28, 2024
-
Use relative file paths for HIE files and Stan's config maps
Stan expects relative paths. Without this change, file names won't map correctly to their associated language extension data, which means no enabled extensions will be detected. This causes annoying false positives with, e.g., the `StrictData` extension. (See issue haskell#3174.)
Configuration menu - View commit details
-
Copy full SHA for 9509b27 - Browse repository at this point
Copy the full SHA 9509b27View commit details
Commits on Jan 30, 2024
-
Un-exclude Stan diagnostics related to
StrictData
We specifically want to test this diagnostic, so we need it to fire.
Configuration menu - View commit details
-
Copy full SHA for 4e95308 - Browse repository at this point
Copy the full SHA 4e95308View commit details -
Add tests to ensure the Stan plugin detects a module's language exten…
…sions Includes test cases for both `LANGUAGE` pragmas and extensions enabled in a project's `.cabal` file.
Configuration menu - View commit details
-
Copy full SHA for 802b46c - Browse repository at this point
Copy the full SHA 802b46cView commit details
Commits on Jan 31, 2024
-
Tighten up Stan plugin language extension test cases
These changes ensure that the tests will fail given bad mappings in either the `cabalExtensionsMap` OR the `checksMap`. Either of these could cause bad behavior as seen in issue haskell#3174.
Configuration menu - View commit details
-
Copy full SHA for c0dac2e - Browse repository at this point
Copy the full SHA c0dac2eView commit details -
Use correct extension/file mappings even in the case of a config fiasco
The Stan plugin will still operate as expected even if we can't load a config -- it will simply default to showing all inspections.
Configuration menu - View commit details
-
Copy full SHA for e6a8520 - Browse repository at this point
Copy the full SHA e6a8520View commit details
Commits on Feb 1, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 430c82d - Browse repository at this point
Copy the full SHA 430c82dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 36e8877 - Browse repository at this point
Copy the full SHA 36e8877View commit details -
Configuration menu - View commit details
-
Copy full SHA for afa2b9b - Browse repository at this point
Copy the full SHA afa2b9bView commit details
Commits on Feb 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 188c767 - Browse repository at this point
Copy the full SHA 188c767View commit details -
Configuration menu - View commit details
-
Copy full SHA for d028cd6 - Browse repository at this point
Copy the full SHA d028cd6View commit details -
Configuration menu - View commit details
-
Copy full SHA for fc2aff0 - Browse repository at this point
Copy the full SHA fc2aff0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1c5e034 - Browse repository at this point
Copy the full SHA 1c5e034View commit details -
Ensure
hs-source-dirs
in test cabal files don't contain path separa……tors Related to (what I assume is) a bug in Stan, or its `extensions` library. Regardless of OS, the `hs-source-dirs` field is prepended as-is to the module name to create the file paths used in the cabal extensions map. This means the maps won't work in Windows if your cabal file contains `/` path separators. Working around the limitation here to ensure tests work on all platforms.
Configuration menu - View commit details
-
Copy full SHA for c24f564 - Browse repository at this point
Copy the full SHA c24f564View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.