Set test options via cabal.project #4039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means we can set the default properly for people using the project, and also set things more simply in the test workflow.
jhrcek
reviewed
Feb 3, 2024
jhrcek
reviewed
Feb 3, 2024
.github/workflows/test.yml
Outdated
| # See https:/ocharles/tasty-rerun/issues/22 for why we need | ||
| # to include 'new' in the filters, since many of our test suites are in the | ||
| # same package. | ||
| run: | | ||
| echo "TEST_OPTS=-j1 --rerun-update --rerun-filter failures,exceptions,new" >> $GITHUB_ENV | ||
| echo 'cabal configure --test-options="--rerun-update --rerun-filter failures,exceptions,new"' >> cabal.project.local |
There was a problem hiding this comment.
I mean this, which has the side effect of writing those options into cabal.project.local
Suggested change
| echo 'cabal configure --test-options="--rerun-update --rerun-filter failures,exceptions,new"' >> cabal.project.local | |
| cabal configure --test-options="--rerun-update --rerun-filter failures,exceptions,new" |
$ cabal configure --test-options="--rerun-update --rerun-filter failures,exceptions,new"
$ cat cabal.project.local
ignore-project: False
test-options: "--rerun-update"
"--rerun-filter"
"failures,exceptions,new"
There was a problem hiding this comment.
That's what I meant to type, just 🤦
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means we can set the default properly for people using the project, and also set things more simply in the test workflow.
The option setting in
hls-test-optionsalso seemed to be simply not working, for reasons I don't fully understand (but it seems likeNumThreadsis a special option.