Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce usage of partial functions #4123

Merged
merged 5 commits into from
Mar 9, 2024
Merged

Reduce usage of partial functions #4123

merged 5 commits into from
Mar 9, 2024

Conversation

jhrcek
Copy link
Collaborator

@jhrcek jhrcek commented Mar 8, 2024

No description provided.

@jhrcek jhrcek marked this pull request as ready for review March 9, 2024 10:46
fendor
fendor approved these changes Mar 9, 2024
View reviewed changes
Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I don't think it is generally a good idea to move tests away from partial functions

ghcide/test/exe/IfaceTests.hs Outdated Show resolved Hide resolved
@jhrcek jhrcek force-pushed the jhrcek/fewer-partial-funs branch from 1573318 to fc2afb9 Compare March 9, 2024 12:27
@jhrcek jhrcek merged commit 91098a4 into master Mar 9, 2024
39 checks passed
@jhrcek jhrcek deleted the jhrcek/fewer-partial-funs branch March 11, 2024 05:52
@chenrui333 chenrui333 mentioned this pull request May 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fendor fendor fendor approved these changes

@santiweight santiweight Awaiting requested review from santiweight santiweight is a code owner

@peterbecich peterbecich Awaiting requested review from peterbecich peterbecich is a code owner

@pepeiborra pepeiborra Awaiting requested review from pepeiborra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhrcek @fendor