Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get rid of the unsafeInterleaveIO at start up #4167

Merged
merged 1 commit into from
Apr 10, 2024
Merged

get rid of the unsafeInterleaveIO at start up #4167

merged 1 commit into from
Apr 10, 2024

Conversation

soulomoon
Copy link
Collaborator

@soulomoon soulomoon commented Apr 9, 2024 •
edited
Loading

It contribute to a hang in #4152
we discover it when doing #4153

@soulomoon
Copy link
Collaborator Author

Does it look good @michaelpj

@soulomoon soulomoon requested a review from michaelpj April 9, 2024 09:47
michaelpj
michaelpj approved these changes Apr 9, 2024
View reviewed changes
Copy link
Collaborator

@michaelpj michaelpj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to me. The existing comment doesn't make much sense to me. If it passes the tests I think it should be fine!

@soulomoon soulomoon merged commit 97aac54 into haskell:master Apr 10, 2024
39 checks passed
@chenrui333 chenrui333 mentioned this pull request May 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelpj michaelpj michaelpj approved these changes

@pepeiborra pepeiborra Awaiting requested review from pepeiborra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soulomoon @michaelpj