Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable test for #717 #4241

Conversation

soulomoon
Copy link
Collaborator

@soulomoon soulomoon commented May 17, 2024

I think we can enable the test for #717 now. Not sure why it won't work before, but it should work now

@soulomoon soulomoon linked an issue May 17, 2024 that may be closed by this pull request
@soulomoon soulomoon marked this pull request as ready for review May 17, 2024 16:40
@soulomoon soulomoon requested a review from wz1000 as a code owner May 17, 2024 16:40
Copy link
Collaborator

@jhrcek jhrcek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soulomoon soulomoon merged commit fb5506c into master May 18, 2024
35 checks passed
@soulomoon
Copy link
Collaborator Author

thanks for the review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hover does not work for type symbols from external packages
2 participants