Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate RootUriTests #4261

Merged
merged 5 commits into from
May 28, 2024
Merged

Migrate RootUriTests #4261

merged 5 commits into from
May 28, 2024

Conversation

soulomoon
Copy link
Collaborator

@soulomoon soulomoon commented May 27, 2024 •
edited
Loading

What's done

  • Add testClientRoot and testServerRoot to TestConfig
  • Migrate RootUriTests

@soulomoon soulomoon marked this pull request as ready for review May 27, 2024 16:39
@soulomoon soulomoon added the status: needs review This PR is ready for review label May 28, 2024
fendor
fendor approved these changes May 28, 2024
View reviewed changes
Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@soulomoon soulomoon enabled auto-merge (squash) May 28, 2024 10:24
@soulomoon soulomoon merged commit 4f7a0fc into master May 28, 2024
35 checks passed
@soulomoon soulomoon mentioned this pull request May 29, 2024
Closed
31 tasks
@BrewTestBot BrewTestBot mentioned this pull request Jun 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fendor fendor fendor approved these changes

@wz1000 wz1000 Awaiting requested review from wz1000 wz1000 is a code owner

Assignees
No one assigned
Labels
status: needs review This PR is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soulomoon @fendor