This repository has been archived by the owner on Feb 3, 2022. It is now read-only.
fix abi depends #293
Merged
fix abi depends #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This undoes the usage of target instead of inplace confs, which was a bad idea. We still need inplace confs to be able to point to artifacts that are not in their final locations. (All this is because without some tricks, things are really not relocatable in the ghc-pkg database). However, because the confs now have abi-depends that can be inaccurate in the inplace case, we're back at the original bug. The solution is a dumb hack -- we just rewrite each generated conf immediately following generation (target and inplace both) to strip out the abi-depends field, which was optional anyway.