Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serverExecutablePath can only be set globally since 1.3.0 #393

Closed
nc6 opened this issue May 11, 2021 · 2 comments
Closed

serverExecutablePath can only be set globally since 1.3.0 #393

nc6 opened this issue May 11, 2021 · 2 comments

Comments

@nc6
Copy link

nc6 commented May 11, 2021

For some projects, I have an overridden haskell-language-server script in the project that sets up the environment correctly (in particular, executes it in the correct nix-shell). This worked well up until 1.3.0, when the serverExecutablePath was set to have only "machine" scope and thus must be configured globally.

The ostensible reason for this change is to prevent somebody from causing arbitrary script execution, but this seems weak - if you're compiling code I have control over, I can do this just as easily through a TH splice. So I'd like to request that this change be reverted.

@nc6
Copy link
Author

nc6 commented May 11, 2021

Ah, my apologies, I see this is a duplicate of #387

@jneira
Copy link
Member

jneira commented May 11, 2021

No worries, good to know how it is impacting users, if you have the opportunity it would be great to know (commenting in the previous issue if possible) what is your workflow, to help in the design of the alternative to the actual situation.

if you're compiling code I have control over, I can do this just as easily through a TH splice

The machine scope would let an attacker execute an arbitrary program simply opening a folder with vscode so i think it doesnt have the same severity imho. The existence of other security holes cant be a excuse to let open another one.

If you dont mind i would prefer to close this one and centralize the info in the mentioned issue.

@jneira jneira closed this as completed May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants