Change server name to avoid confusion #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💖 Thanks for opening this pull request! 💖 If your PR gets accepted and merged in, we will invite you to the project 🎉 |
callelj
previously approved these changes
Oct 18, 2018
|
I do not agree on the change since that would display motionEye twice in the header, which just look ugly as freaking h*ll as well. Secondly, the icon differs...? |
frenck
approved these changes
Oct 23, 2018
|
Congrats on merging your first pull request! 🎉🎉🎉 |
|
This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
The current server name can get a bit confusing since it changes the title of the motionEye page.
The only way to know the tab is for motionEye if from the icon:
This changes the server name to
motionEye | Hass.ioso the title is more distinguishable.