Upgrade to Hidden Service v3

[foo-calls-bar]

I only submit this patch because from the open issues it appears this essential addon is at risk of becoming totally useless by October when all tor browsers will officially be incompatible with v2, and that would be a shame.

Proposed Changes

Change HiddenServiceVersion from 2 to 3 in order for this addon to survive the impending depreciation of v2. Patch is fully tested as Local Addon. No issues, though users will obviously have to take note of the new domain & update any bookmarks to the old one. I

Related Issues

(Github link to related issues or pull requests)

[frenck]

I have a hard time believing this is all that is needed to change.

[Seamus-Mccartin]

I simulated this change by overwriting the torrc configuration file before the service starts with:
docker cp ~/docker/tor/torrc 6ed88f6762d6:/etc/tor/torrc

Changing the service version from 2 to 3 the service will generate new keys and overwrite the hosts file with the new V3 address.
It really does seem to be that simple. Probably because this would be the expected behavior when someone updates tor to a version that defaults to v3 since this value usually isn't explicitly set.

Sometime in October, the tor network will drop support for routing v2 addresses entirely. Currently, as nodes are updating, v2 address will progressively get harder to reach up until the October deadline. This can already be seen in several of my clients' log files where they have to repeatedly try introductory points to find one that still supports v2.

[foo-calls-bar]

I have a hard time believing this is all that is needed to change.

It really is though. Try it yourself. I've been remotely accessing my server as a v3 service for over a month now without any problems. And when you think about it, it make sense (if you've ever run or configured Tor on a Linux system, anyway). This patch simply alters the contents written to the dynamic torrc prior to execution, so when Tor starts it creates the expected certificates where they don't yet exist.

[sveip]

Just checking if this is planned to be accepted and merged or not. No rush, just that otherwise, I'll have to start looking into alternatives.

[ghgeiger]

I would like to kindly ask that this PR get merged sooner rather than later. I've personally had a very difficult time finding any vpn server that will work with my internet provider and this add-on is the easiest way for me to access my network from afar, not just HA, but other devices as well. This add-on will become obsolete if it is not updated.

The following is quoted from torproject's wiki on the subject:

"It's easy! Just use your regular onion service torrc and add HiddenServiceVersion 3 in your hidden service torrc block."

From the tor log on HA:

Sep 24 10:42:22.308 [warn] DEPRECATED: Onion service version 2 are deprecated. Please use version 3 which is the default now. Currently, version 2 is planned to be obsolete in the Tor version 0.4.6 stable series.

[frenck]

Rebased PR onto the latest main branch.

[frenck]

Just checking if this is planned to be accepted and merged or not

Sorry for the delay, my holiday did not end as planned. I'm slowly catching up.

[frenck]

Thanks, @foo-calls-bar 👍

[bluenix]

This may be sufficient for enabling v3, but it will only create a publicly exposed v3 onion service. It does not replace the stealth v2 with v3 client authorization, which will result in all the stealth onions that were set up using this addon being publicly reachable on upgrade.

[frenck]

@bluenix This is a merged and closed PR. Commenting something like that doesn't help, cannot be tracked for progress or fixed. If you have an issue, please raise an issue. Thanks 👍