Issue 44 - Support Hibernate 5.3.x #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bturner
approved these changes
Nov 25, 2018
...t-hibernate53/src/main/java/com/hazelcast/hibernate/AbstractHazelcastCacheRegionFactory.java
Outdated
Show resolved
Hide resolved
| ); | ||
| } | ||
|
|
||
| protected abstract RegionCache createTimestampsRegionCache(String regionName, |
There was a problem hiding this comment.
More here. Perhaps one of the Hazelcast maintainers can link us to something re: their code style
hazelcast-hibernate53/src/main/java/com/hazelcast/hibernate/RegionCache.java
Show resolved
Hide resolved
hazelcast-hibernate53/src/main/java/com/hazelcast/hibernate/local/LocalRegionCache.java
Outdated
Show resolved
Hide resolved
29 tasks
leszko
approved these changes
Nov 28, 2018
There was a problem hiding this comment.
Thanks @dohertyfjatl for the PR. It's a piece of great work 👍
I'll merge it and we'll release it soon.
What I'm a little concerned is that for each version we create a new project and copy the source, which is hard to maintain. I think we should integrate this project back to hazelcast-hibernate and use versions to distinguish the Hibernate versions. Anyway, it's a separate topic and we can do it later.
|
Thank you so much, we were waiting for it. |
|
FYI: hazelcast-hibernate53 (v1.3.0) is released. |
|
Awesome, thanks a lot!! I will test tomorrow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements issue #44 by adding a new module, "hazelcast-hibernate53", which adds support for Hibernate 5.3.x: