Use predefined service uuids #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlech
reviewed
Dec 30, 2021
|
Thanks for updating. The |
On macos the service_uuids need to be filled. Main issue for beginners is to retrieve some valid uuids. Instead of using an external tool like nRF we could use predefined ones in bleak/uuids. Implementation works with 128bit and 16bit UUIDs. Related-to hbldh#635 Signed-off-by: Marc Koderer <[email protected]>
|
Should pass now |
|
Thanks! |
|
Very good, thank you! This is an essential addition to the example. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On macos the service_uuids need to be filled. Main issue for
beginners is to retrieve some valid uuids. Instead of using an
external tool like nRF we could use predefined ones in bleak/uuids.
Implementation works with 128bit and 16bit UUIDs.
Related-to #635
Signed-off-by: Marc Koderer [email protected]