BlueZ: fix removed devices included in discovered_devices #967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bdraco can you please test? |
|
Will give it a shot 👍 Thanks |
bdraco
reviewed
Aug 29, 2022
bleak/backends/bluezdbus/scanner.py
Outdated
| Handles a device being removed from BlueZ. | ||
| """ | ||
| try: | ||
| self._devices[device_path] |
There was a problem hiding this comment.
Suggested change
| self._devices[device_path] | |
| del self._devices[device_path] |
Should this be del?
|
Been testing this for a few hours with the above Devices are going unavailable when they disappear now. |
|
To make sure it is effective I did another test by setting up a humidity sensor. You can see from the graph when I took the batteries out as the device goes unavailable a few minutes later. The holes in the graph are from the latest test where I removed the batteries and later replaced them each time. |
bdraco
approved these changes
Aug 30, 2022
|
Tested with an extended battery removal as well. Recovered quickly This all looks good with the |
…d_devices This fixes a regression introduced in v0.15 where device removed from BlueZ while scanning were no longer removed from this list of discovered devices. This caused the `discovered_devices` property to return devices that could no longer be connected to by BlueZ since they were removed. Fixes #942.
dlech
force-pushed
the
bluez-fix-device-removed-while-scanning
branch
from
d2441c4
to
aa27f4c
Compare
|
Thanks for testing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression introduced in v0.15 where device removed from BlueZ while scanning were no longer removed from this list of discovered devices. This caused the
discovered_devicesproperty to return devices that could no longer be connected to by BlueZ since they were removed.Fixes #942.