Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update contributing.md #134

Merged
merged 4 commits into from
Jun 9, 2021
Merged

Update contributing.md #134

merged 4 commits into from
Jun 9, 2021

Conversation

sandro-elsweijer
Copy link
Member

Closes #132

@sandro-elsweijer sandro-elsweijer self-assigned this May 14, 2021
PhiSpel
PhiSpel requested changes May 14, 2021
View reviewed changes
Copy link
Collaborator

@PhiSpel PhiSpel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice, only very few optional things

CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
PhiSpel
PhiSpel approved these changes Jun 9, 2021
View reviewed changes
Copy link
Collaborator

@PhiSpel PhiSpel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@PhiSpel PhiSpel merged commit 20df97e into master Jun 9, 2021
@joergbrech joergbrech deleted the 132-se/Update-CONTRIBUTING.md branch August 5, 2021 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhiSpel PhiSpel PhiSpel approved these changes

Assignees

@sandro-elsweijer sandro-elsweijer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update CONTRIBUTING.md
2 participants
@sandro-elsweijer @PhiSpel