Vertical alignment #108
Merged
Vertical alignment #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new boxes are:
- `this._download_box`: contains all download section items
- `this._upload_box`: contains all upload section items
- `this._sum_box`: contains all sum (download+upload) section items
- `this._metrics_box`: contains all the previous ones
The new tree layout is:
- box
- metrics_box
- download_box
- down
- downunit
- downicon
- upload_box
- up
- upunit
- upicon
- sumbox
- sum
- sumunit
- icon_box
- icon
This style should work with the default panel; it may produce artifacts with shell themes or extensions which change the panel (e.g. DashToPanel)
|
@hedayaty could you please review this? |
|
@hedayaty please check this out and let me know what you think 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#73