Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new service Buffer #361

Merged
merged 4 commits into from
Apr 1, 2019
Merged

Conversation

richard67
Copy link
Contributor

@richard67 richard67 commented Mar 23, 2019

This pull request (P) adds the new service "Buffer" for buffer to Shariff.

Buffer is something very similar to AddThis.

The URL for the button I found here: https:/bradvin/social-share-urls#buffer.

Buffer also provides share counts. A PR to add the "Buffer" service to Shariff-Backend-PHP can be found here: heiseonline/shariff-backend-php#155.

Dependencies

This PR requires PR #360 in order to have an icon for Buffer.

About button colors

The original sharing button of Buffer has black logo on grey background, and their sharing count has some kind of green background, see here: https://buffer.com/extras/button:
buffer-button-original
This design does not really fit to Shariff.

On their website, buffer.com have sharing buttons on their own pages.
They look as follows:
sharing-buttons-at-buffer-com-pages
There is no hover effect.

Another thing I found was a Wordpress plugin with buttons looking as follows:
screenshot-1

(Buffer button is the leftmost one in both examples).

So I've decided for following button colors, with color numbers picked from the official buffer icon:

Standard theme:
buffer-button-new

Grey theme:
buffer-button-new-grey

Standard or grey theme hovered:
buffer-button-new-hover

White theme:
buffer-button-new-white

White theme hovered:
buffer-button-new-white-hover

How to test:

The test is done with a branch which includes the changes from PR #360 and this PR here.

Run the shariff demo site locally on a Linux host which has git and npm installed with the branch of this PR as follows:

$ mkdir shariff-test-pr361
$ cd shariff-test-pr361
$ git clone https:/richard67/shariff-plus.git
$ cd shariff-plus
$ git checkout upstream-test-buffer
$ git pull origin upstream-test-buffer
$ npm install
$ npm run dev

Check the result in the browser, URL=http://localhost:3000/.

Check the result

Verify that a new button for Buffer has been added at the end of examples 2, 3 and 4 of the demo, that the buffer icon fits to the brand icon on https://buffer.com/, that the button colors are as described above, and that the sharing links work and use the right title and URL.

Clean up after the test

$ cd ../..
$ rm -rf ./shariff-test-pr361

@richard67
Copy link
Contributor Author

@compeak @liayn Do you think I should change colors of the button so they fit to the original button, see secion "About button color: Suggestions are welcome" in description above?

@liayn
Copy link
Contributor

liayn commented Mar 24, 2019

I think the color is fine, especially as they mention it in their styles guide

@richard67
Copy link
Contributor Author

Well, they mention it, but not for their sharing button, that’s why I am not sure.
Thanks for the feedback.

@richard67
Copy link
Contributor Author

richard67 commented Mar 31, 2019

@liayn @compeak I just noticed that buffer.com have sharing buttons on their own pages.
They look as follows:
sharing-buttons-at-buffer-com-pages
There is no hover effect.

Another thing I found was a Wordpress plugin with buttons looking as follows:
screenshot-1

(Buffer button is the leftmost one in both examples).

So it seems the blue color I have chosen is not the right one for people to recognize the Buffer button.

First example is a very dark grey, second one looks a little bit lighter (or transparent?).

Colors could be picked from official Buffer icon which I have downloaded, e.g. #555555 for the very dark grey.

Hovering effect I would have to chose some lighter grey on my own.

Guys what do you think? Should I go this way?

@richard67
Copy link
Contributor Author

@liayn @compeak I've decided myself and changed colors. I'll update description above.

@compeak compeak self-assigned this Apr 1, 2019
@compeak compeak merged commit ab7bb3b into heiseonline:develop Apr 1, 2019
@compeak
Copy link
Collaborator

compeak commented Apr 1, 2019

Thank you.

@richard67 richard67 deleted the upstream-add-buffer branch April 2, 2019 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants