Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request (P) adds the new service "Buffer" for buffer to Shariff.
Buffer is something very similar to AddThis.
The URL for the button I found here: https:/bradvin/social-share-urls#buffer.
Buffer also provides share counts. A PR to add the "Buffer" service to Shariff-Backend-PHP can be found here: heiseonline/shariff-backend-php#155.
Dependencies
This PR requires PR #360 in order to have an icon for Buffer.
About button colors
The original sharing button of Buffer has black logo on grey background, and their sharing count has some kind of green background, see here: https://buffer.com/extras/button:
This design does not really fit to Shariff.
On their website, buffer.com have sharing buttons on their own pages.
They look as follows:
There is no hover effect.
Another thing I found was a Wordpress plugin with buttons looking as follows:
(Buffer button is the leftmost one in both examples).
So I've decided for following button colors, with color numbers picked from the official buffer icon:
Standard theme:
Grey theme:
Standard or grey theme hovered:
White theme:
White theme hovered:
How to test:
The test is done with a branch which includes the changes from PR #360 and this PR here.
Run the shariff demo site locally on a Linux host which has git and npm installed with the branch of this PR as follows:
Check the result in the browser, URL=
http://localhost:3000/
.Check the result
Verify that a new button for Buffer has been added at the end of examples 2, 3 and 4 of the demo, that the buffer icon fits to the brand icon on https://buffer.com/, that the button colors are as described above, and that the sharing links work and use the right title and URL.
Clean up after the test
$ cd ../.. $ rm -rf ./shariff-test-pr361