made xinetd.aug case insensitive on attribute names #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| | "disable" | "max_load" | "rlimit_as" | "rlimit_cpu" | ||
| | "rlimit_data" | "rlimit_rss" | "rlimit_stack" | "v6only" | ||
| | "deny_time" | "umask" | "mdns" | "libwrap") | ||
| attr_one (/socket_type|protocol|wait|user|group|server|instances|rpc_version|rpc_number|id|port|nice|banner|bind|interface|per_source|groups|banner_success|banner_fail|disable|max_load|rlimit_as|rlimit_cpu|rlimit_data|rlimit_rss|rlimit_stack|v6only|deny_time|umask|mdns|libwrap/i) |
There was a problem hiding this comment.
Could you split this line to keep it under 80 columns, please?
|
I can't. I have problem with rewritting regexp. e.g., if I rewrite my regext (1) to (2) which should be equivalent to (3) then the patch is not working. As a reaction to this discussion, I've added and got same regexp for all above regexps. Moreover, augparse xinetd.aug has a problem with later one regexp ( (3) ) and reports So, whats wrong? |
|
I just merged the pull request - thanks for submitting it. The problem with splitting the regexps is a real problem; I have a patch for part of the problem, but not all of it. The partial fix is in commit 4c1a223 |
|
Actually, that commit seems to fix the problem completely. At least the reformatted xinetd lens from commit b7c6216 works. |
thedrow
added a commit
to thedrow/augeas
that referenced
this pull request
Sep 30, 2016
# This is the 1st commit message: Use the address sanitizer in CI. Cache compilation result and compile in parallel. # This is the commit message hercules-team#2: show config.log on failure. # This is the commit message hercules-team#3: Set compiler to GCC 6 explicitly. # This is the commit message hercules-team#4: upgrade linker. # This is the commit message hercules-team#5: Try upgrading ld. # This is the commit message hercules-team#6: Require sudo. # This is the commit message hercules-team#7: Move to trusty. # This is the commit message hercules-team#8: Upgrade binutils from PPA. # This is the commit message hercules-team#9: Print exit code. # This is the commit message hercules-team#10: Install selinux in order to pass the build. # This is the commit message hercules-team#1: Fold error. # This is the commit message hercules-team#2: Upgrade autotools. # This is the commit message hercules-team#3: Extract install section to script. # This is the commit message hercules-team#4: Fix name of ppa:ubuntu-toolchain-r/test. # This is the commit message hercules-team#5: Add -y. # This is the commit message hercules-team#6: Use correct path for config.log. # This is the commit message hercules-team#7: Fix spelling. # This is the commit message hercules-team#8: Added test script. # This is the commit message hercules-team#9: Cache compilation result. # This is the commit message hercules-team#10: Show test suite error log. # This is the commit message hercules-team#1: Fold error. # This is the commit message hercules-team#2: Correct ld and c flang.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xinetd is case insensitive on attribute names since version 2.3.4
see: http://www.xinetd.org/cgi-bin/cvsweb.cgi/xinetd/CHANGELOG?annotate=1.1