Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[The Magic Highlighter] Add support for Google Hong Kong (google.com.hk) #27

Open
1 task done
s-bz opened this issue Apr 18, 2023 · 2 comments
Open
1 task done
Labels
enhancement request Feedback about enhancements to EXISTING product features up next These issues are next up in our priority queue

Comments

@s-bz
Copy link

s-bz commented Apr 18, 2023

Product

The Magic Highlighter

Subject

No highlights when coming from Google HK

Feedback

I purchased the magic highlighter at launch but it never worked for me. I believe it’s because I use Google Hong Kong - as it works perfectly fine when I force using Google.com.

Could you add support for it? https://www.google.com.hk/search?q=daring+fireball+iphone+14&ie=UTF-8&oe=UTF-8&hl=en&client=safari

Thanks !

Context

No response

Code of Conduct

  • I have read and agree to the Herd Works Product Feedback Issue Tracker project's Code of Conduct
@s-bz s-bz added the bug Something isn't working label Apr 18, 2023
@calebhailey calebhailey changed the title [Magic highlighter] not working on Google Hong Kong [The Magic Highlighter] Add support for Google Hong Kong (google.com.hk) Apr 19, 2023
@calebhailey calebhailey added enhancement request Feedback about enhancements to EXISTING product features and removed bug Something isn't working labels Apr 19, 2023
@calebhailey
Copy link
Member

I had been hesitant to add support for Google.com.hk because I was unsure about Mandarin and Cantonese character support, which uncertainty seems to be verified by #26. Furthermore, I'm not sure if that (#26) is a problem I'm going to be able to resolve very quickly, and even if I could, I wouldn't know how to test it to know if a potential fix would make sense in those languages.

@s-bz would Google.com.hk support still make sense even if The Magic Highlighter doesn't support Mandarin or Cantonese? If so this should be an easy enhancement. 😊

@s-bz
Copy link
Author

s-bz commented Apr 19, 2023

Thanks for sharing the background.

I think there is value in supporting Latin characters in any Google versions you can, including HK.

Separately, I’d suggest adding a note on the App Store product page about what is not supported (Canto / Mandarin for example) then let users decide whether to buy it or not knowing the limitations.

Thanks

@calebhailey calebhailey added in progress We are actively working on this! up next These issues are next up in our priority queue and removed in progress We are actively working on this! labels May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement request Feedback about enhancements to EXISTING product features up next These issues are next up in our priority queue
Projects
None yet
Development

No branches or pull requests

2 participants